Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(846)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1605093002: MIPS64: Use the Lsa() and Dlsa() macro/r6 instructions in existing code. (Closed)

Created:
4 years, 11 months ago by balazs.kilvady
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: Use the Lsa() and Dlsa() macros/r6 instructions in existing code. BUG= Committed: https://crrev.com/b3517e2b4b2d5d9425a99451ccdfd6cd39c98867 Cr-Commit-Position: refs/heads/master@{#33430}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -127 lines) Patch
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 9 chunks +10 lines, -20 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/ic/mips64/stub-cache-mips64.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 23 chunks +27 lines, -50 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 8 chunks +11 lines, -25 lines 0 comments Download
M src/mips64/codegen-mips64.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/mips64/deoptimizer-mips64.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 6 chunks +8 lines, -16 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
balazs.kilvady
PTAL optdebug.check tests passed on r6 and r2 mips64el sim.
4 years, 11 months ago (2016-01-19 19:26:15 UTC) #3
ivica.bogosavljevic
lgtm
4 years, 11 months ago (2016-01-21 07:17:05 UTC) #4
ivica.bogosavljevic
lgtm
4 years, 11 months ago (2016-01-21 07:17:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1605093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1605093002/1
4 years, 11 months ago (2016-01-21 10:26:31 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-21 10:45:29 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 10:45:49 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/b3517e2b4b2d5d9425a99451ccdfd6cd39c98867
Cr-Commit-Position: refs/heads/master@{#33430}

Powered by Google App Engine
This is Rietveld 408576698