Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 160505: Activate scrollbars (etc.) upon selecting a tab.... (Closed)

Created:
11 years, 4 months ago by viettrungluu-gmail
Modified:
9 years, 7 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews_googlegroups.com, brettw, Ben Goodger (Google)
Visibility:
Public.

Description

Activate scrollbars (etc.) upon selecting a tab. (Conceivably, the SetActive() could be pushed into the RWHV's DidBecomeSelected(). Conceivably, one could imagine selection without activation, so I chose to put it closer to the UI side of the code in the TabContents. Hmmm. Maybe we should also put in the RWHV::SetActive() method on all platforms.) BUG=18262 TEST=Make your browser window really small, create new tabs, switch between them.

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome/browser/tab_contents/tab_contents.cc View 1 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Avi (use Gerrit)
LG; should you set SetActive(false) on switching out the tab?
11 years, 4 months ago (2009-08-04 14:48:15 UTC) #1
viettrungluu-gmail
On 2009/08/04 14:48:15, Avi wrote: > LG; should you set SetActive(false) on switching out the ...
11 years, 4 months ago (2009-08-04 17:50:52 UTC) #2
Avi (use Gerrit)
Cool. Well, go for the commit then.
11 years, 4 months ago (2009-08-04 19:06:05 UTC) #3
Avi (use Gerrit)
11 years, 4 months ago (2009-08-04 21:59:56 UTC) #4
On 2009/08/04 19:06:05, Avi wrote:
> Cool. Well, go for the commit then.

Committed r22422.

Powered by Google App Engine
This is Rietveld 408576698