src/gpu/text/GrAtlasTextContext.cpp - Issue 1605013002: Fix GrAtlasTextBlob bounds management

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/text/GrAtlasTextContext.cpp

Issue 1605013002: Fix GrAtlasTextBlob bounds management (Closed) Base URL: https://skia.googlesource.com/skia.git@cleanuptext17

Patch Set: clean up patch Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/gpu/text/GrAtlasTextContext.cpp

diff --git a/src/gpu/text/GrAtlasTextContext.cpp b/src/gpu/text/GrAtlasTextContext.cpp

index e286aa6d0f8965d818b7101640cda55d5ee9653c..d491da901e7e534fe26045616715760027ef80fb 100644

--- a/src/gpu/text/GrAtlasTextContext.cpp

+++ b/src/gpu/text/GrAtlasTextContext.cpp

@@ -281,7 +281,7 @@ GrAtlasTextContext::createDrawTextBlob(const GrPaint& paint, const SkPaint& skPa

int glyphCount = skPaint.countText(text, byteLength);

GrAtlasTextBlob* blob = fCache->createBlob(glyphCount, 1, GrAtlasTextBlob::kGrayTextVASize);

- blob->initThrowawayBlob(viewMatrix);

+ blob->initThrowawayBlob(viewMatrix, x, y);

if (GrTextUtils::CanDrawAsDistanceFields(skPaint, viewMatrix, fSurfaceProps,

*fContext->caps()->shaderCaps())) {

@@ -304,7 +304,7 @@ GrAtlasTextContext::createDrawPosTextBlob(const GrPaint& paint, const SkPaint& s

int glyphCount = skPaint.countText(text, byteLength);

GrAtlasTextBlob* blob = fCache->createBlob(glyphCount, 1, GrAtlasTextBlob::kGrayTextVASize);

- blob->initThrowawayBlob(viewMatrix);

+ blob->initThrowawayBlob(viewMatrix, offset.x(), offset.y());

if (GrTextUtils::CanDrawAsDistanceFields(skPaint, viewMatrix, fSurfaceProps,

*fContext->caps()->shaderCaps())) {