Set intrinsic size for inline SVG earlier

Set intrinsic size for inline SVG earlier

LayoutReplaced has a m_intrinsicSize that's updated when computing
logical widths and heights (and only if needed; specified style makes
it not being set at all).

But m_intrinsicSize can be used earlier that that, when computing
preferred widths for the container, see
LayoutReplaced::computeIntrinsicLogicalWidths called from
LayoutReplaced::computePreferredLogicalWidths().

This patch computes the intrinsic size in the constructor to avoid
returning the stale default size.

BUG=468897
Committed: https://crrev.com/545b2183e1b4ee3eb433537f9a6386b5337d6588
Cr-Commit-Position: refs/heads/master@{#370388}

[davve, 2016-01-19 16:12:22]

davve@opera.com changed reviewers:
+ fs@opera.com

[davve, 2016-01-19 16:12:23]

PTAL

[fs, 2016-01-19 16:23:05]

lgtm

[davve, 2016-01-20 12:13:58]

Had to do some extra work for the default intrinsic size to keep working.

I'm also looking into moving the default intrinsic size to the end of the sizing
algorithm, for better compliance with the spec. Doing so would avoid the default
size giving intrinsic aspect ratio. Which it shouldn't according to spec but
does currently.

[fs, 2016-01-20 13:12:20]

On 2016/01/20 at 12:13:58, davve wrote:
> Had to do some extra work for the default intrinsic size to keep working.

Ok. Still LGTM.

> I'm also looking into moving the default intrinsic size to the end of the
sizing algorithm, for better compliance with the spec. Doing so would avoid the
default size giving intrinsic aspect ratio. Which it shouldn't according to spec
but does currently.

Roger. Got me thinking of crbug.com/475009, but that's probably not related.

[davve, 2016-01-20 13:21:08]

The CQ bit was checked by davve@opera.com

[commit-bot: I haz the power, 2016-01-20 13:21:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1604993003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1604993003/40001

[davve, 2016-01-20 13:33:19]

On 2016/01/20 13:12:20, fs wrote:

> Roger. Got me thinking of crbug.com/475009, but that's probably not related.

Wouldn't be surprised. It's in the corner cases it creeps up. The normal <svg>
inline case is fine. (<video> is not, but apparently the spec changed there
recently).

[commit-bot: I haz the power, 2016-01-20 14:45:23]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-20 14:46:20]

Description was changed from

==========
Set intrinsic size for inline SVG earlier

LayoutReplaced has a m_intrinsicSize that's updated when computing
logical widths and heights (and only if needed; specified style makes
it not being set at all).

But m_intrinsicSize can be used earlier that that, when computing
preferred widths for the container, see
LayoutReplaced::computeIntrinsicLogicalWidths called from
LayoutReplaced::computePreferredLogicalWidths().

This patch computes the intrinsic size in the constructor to avoid
returning the stale default size.

BUG=468897
==========

to

==========
Set intrinsic size for inline SVG earlier

LayoutReplaced has a m_intrinsicSize that's updated when computing
logical widths and heights (and only if needed; specified style makes
it not being set at all).

But m_intrinsicSize can be used earlier that that, when computing
preferred widths for the container, see
LayoutReplaced::computeIntrinsicLogicalWidths called from
LayoutReplaced::computePreferredLogicalWidths().

This patch computes the intrinsic size in the constructor to avoid
returning the stale default size.

BUG=468897

Committed: https://crrev.com/545b2183e1b4ee3eb433537f9a6386b5337d6588
Cr-Commit-Position: refs/heads/master@{#370388}
==========

[commit-bot: I haz the power, 2016-01-20 14:46:21]

Patchset 3 (id:??) landed as
https://crrev.com/545b2183e1b4ee3eb433537f9a6386b5337d6588
Cr-Commit-Position: refs/heads/master@{#370388}