SkStream/Priv cleanups

SkStream/Priv cleanups

Replace all callers of SkCopyStreamToStorage with SkCopyStreamToData,
which is simpler and does the same thing.

Remove SkStreamRewindableFromSkStream, which is unused.

BUG=skia:4788
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1604963002

Committed: https://skia.googlesource.com/skia/+/a913275bda105fd545af471b724d7e8c1dacb9ae

[scroggo, 2016-01-19 15:15:04]

Description was changed from

==========
SkStream/Priv cleanups

Replace all callers of SkCopyStreamToStorage with SkCopyStreamToData,
which is simpler and does the same thing.

Remove SkStreamRewindableFromSkStream, which is unused.

BUG=skia:4788
==========

to

==========
SkStream/Priv cleanups

Replace all callers of SkCopyStreamToStorage with SkCopyStreamToData,
which is simpler and does the same thing.

Remove SkStreamRewindableFromSkStream, which is unused.

BUG=skia:4788
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[scroggo, 2016-01-19 15:19:38]

scroggo@google.com changed reviewers:
+ msarett@google.com

[scroggo, 2016-01-19 15:19:39]

https://codereview.chromium.org/1604963002/diff/1/src/core/SkStream.cpp
File src/core/SkStream.cpp (right):

https://codereview.chromium.org/1604963002/diff/1/src/core/SkStream.cpp#newco...
src/core/SkStream.cpp:889: return SkData::NewFromStream(stream,
stream->getLength());
I was initially worried that this would not work for streams that started off
partially read, but SkCopyStreamToStorage did not either.

https://codereview.chromium.org/1604963002/diff/1/src/images/SkImageDecoder_a...
File src/images/SkImageDecoder_astc.cpp (right):

https://codereview.chromium.org/1604963002/diff/1/src/images/SkImageDecoder_a...
src/images/SkImageDecoder_astc.cpp:47: SkAutoTUnref<SkData>
data(SkCopyStreamToData(stream));
Alternatively, we can just delete this class. No one is using it, and we can
look at the history if we want to use this code to create a new codec version.

https://codereview.chromium.org/1604963002/diff/1/src/images/SkImageDecoder_l...
File src/images/SkImageDecoder_libbmp.cpp (right):

https://codereview.chromium.org/1604963002/diff/1/src/images/SkImageDecoder_l...
src/images/SkImageDecoder_libbmp.cpp:100: SkAutoTUnref<SkData>
data(SkCopyStreamToData(stream));
I think we'll need this one to support Corey until we can get an
SkCodec/SkImageGenerator replacement. (I assume he'll want to be able to build
on Android and possibly Linux, which have no system version analogous to
SkImageDecoder_CG/_WIC.)

[msarett, 2016-01-19 15:32:24]

lgtm

https://codereview.chromium.org/1604963002/diff/1/src/core/SkStream.cpp
File src/core/SkStream.cpp (right):

https://codereview.chromium.org/1604963002/diff/1/src/core/SkStream.cpp#newco...
src/core/SkStream.cpp:889: return SkData::NewFromStream(stream,
stream->getLength());
On 2016/01/19 15:19:38, scroggo wrote:
> I was initially worried that this would not work for streams that started off
> partially read, but SkCopyStreamToStorage did not either.

Acknowledged.

Should the documentation be updated to reflect the fact that this doesn't work
for partially read streams?

https://codereview.chromium.org/1604963002/diff/1/src/images/SkImageDecoder_a...
File src/images/SkImageDecoder_astc.cpp (right):

https://codereview.chromium.org/1604963002/diff/1/src/images/SkImageDecoder_a...
src/images/SkImageDecoder_astc.cpp:47: SkAutoTUnref<SkData>
data(SkCopyStreamToData(stream));
On 2016/01/19 15:19:39, scroggo wrote:
> Alternatively, we can just delete this class. No one is using it, and we can
> look at the history if we want to use this code to create a new codec version.

I'm not sure how complex deleting ASTC is.  If it's (almost) as simple as
removing this file, then I would say let's go ahead and delete.

However, I suspect that there are tests that need to be deleted along with it
(and I'm not 100% sure that there aren't any users).  If this might be
complicated, it probably makes sense to just land this as is.

https://codereview.chromium.org/1604963002/diff/1/src/images/SkImageDecoder_l...
File src/images/SkImageDecoder_libbmp.cpp (right):

https://codereview.chromium.org/1604963002/diff/1/src/images/SkImageDecoder_l...
src/images/SkImageDecoder_libbmp.cpp:100: SkAutoTUnref<SkData>
data(SkCopyStreamToData(stream));
On 2016/01/19 15:19:39, scroggo wrote:
> I think we'll need this one to support Corey until we can get an
> SkCodec/SkImageGenerator replacement. (I assume he'll want to be able to build
> on Android and possibly Linux, which have no system version analogous to
> SkImageDecoder_CG/_WIC.)

Acknowledged.

[scroggo, 2016-01-19 15:41:26]

https://codereview.chromium.org/1604963002/diff/1/src/core/SkStream.cpp
File src/core/SkStream.cpp (right):

https://codereview.chromium.org/1604963002/diff/1/src/core/SkStream.cpp#newco...
src/core/SkStream.cpp:889: return SkData::NewFromStream(stream,
stream->getLength());
On 2016/01/19 15:32:23, msarett wrote:
> On 2016/01/19 15:19:38, scroggo wrote:
> > I was initially worried that this would not work for streams that started
off
> > partially read, but SkCopyStreamToStorage did not either.
> 
> Acknowledged.
> 
> Should the documentation be updated to reflect the fact that this doesn't work
> for partially read streams?

Done.

[scroggo, 2016-01-19 15:41:32]

The CQ bit was checked by scroggo@google.com

[scroggo, 2016-01-19 15:41:32]

The patchset sent to the CQ was uploaded after l-g-t-m from msarett@google.com
Link to the patchset: https://codereview.chromium.org/1604963002/#ps20001
(title: "Update header description")

[commit-bot: I haz the power, 2016-01-19 15:41:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1604963002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1604963002/20001

[commit-bot: I haz the power, 2016-01-19 15:53:41]

Description was changed from

==========
SkStream/Priv cleanups

Replace all callers of SkCopyStreamToStorage with SkCopyStreamToData,
which is simpler and does the same thing.

Remove SkStreamRewindableFromSkStream, which is unused.

BUG=skia:4788
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
SkStream/Priv cleanups

Replace all callers of SkCopyStreamToStorage with SkCopyStreamToData,
which is simpler and does the same thing.

Remove SkStreamRewindableFromSkStream, which is unused.

BUG=skia:4788
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/a913275bda105fd545af471b724d7e8c1dacb9ae
==========

[commit-bot: I haz the power, 2016-01-19 15:53:45]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/a913275bda105fd545af471b724d7e8c1dacb9ae