Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 1604923003: Import the contents of //third_party/breakpad/linux from Chromium. (Closed)

Created:
4 years, 11 months ago by viettrungluu
Modified:
4 years, 11 months ago
Reviewers:
kulakowski
CC:
mojo-reviews_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Import the contents of //third_party/breakpad/linux from Chromium. (Chromium revision d16fc58435b9515a629b7a6a813ab5b33c1babf5, but these files haven't changed in years. In Chromium, it was in //breakpad/linux; the includes in generate-test-dump.cc were fixed accordingly.) This makes //third_party/breakpad/BUILD.gn valid, the generate_test_dump and breakpad_unittests targets build (on Linux), and "gn check //third_party/breakpad/*" pass. R=kulakowski@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/cd41c8af357afe05b279e78cb02a51b6ee112f77

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -37 lines) Patch
A + third_party/breakpad/linux/breakpad_googletest_includes.h View 2 chunks +8 lines, -5 lines 0 comments Download
A + third_party/breakpad/linux/generate-test-dump.cc View 3 chunks +38 lines, -32 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
viettrungluu
4 years, 11 months ago (2016-01-19 20:27:32 UTC) #1
kulakowski
lgtm
4 years, 11 months ago (2016-01-19 20:45:08 UTC) #2
viettrungluu
4 years, 11 months ago (2016-01-19 20:48:58 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cd41c8af357afe05b279e78cb02a51b6ee112f77 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698