src/interpreter/bytecode-array-builder.cc - Issue 1604923002: [Interpreter] Always store current context in the frames context slot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/interpreter/bytecode-array-builder.cc

Issue 1604923002: [Interpreter] Always store current context in the frames context slot. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@int_fix_block_context_scope

Patch Set: Rebase Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/interpreter/bytecode-array-builder.cc

diff --git a/src/interpreter/bytecode-array-builder.cc b/src/interpreter/bytecode-array-builder.cc

index 12b474451fa69a77ce83821bc8fbc0eb145a027a..c513663a2f97e06d713ae2c418227d597dcf2218 100644

--- a/src/interpreter/bytecode-array-builder.cc

+++ b/src/interpreter/bytecode-array-builder.cc

@@ -1341,7 +1341,7 @@ bool BytecodeArrayBuilder::RegisterIsValid(Register reg,

return false;

}

- if (reg.is_function_context() || reg.is_function_closure() ||

+ if (reg.is_current_context() || reg.is_function_closure() ||

reg.is_new_target()) {

return true;

} else if (reg.is_parameter()) {

« no previous file with comments | « src/ia32/builtins-ia32.cc ('k') | src/interpreter/bytecode-generator.h » ('j') | no next file with comments »