Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: src/x87/builtins-x87.cc

Issue 1604923002: [Interpreter] Always store current context in the frames context slot. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@int_fix_block_context_scope
Patch Set: Rebase Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/x64/builtins-x64.cc ('k') | test/cctest/interpreter/test-bytecode-generator.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_X87 5 #if V8_TARGET_ARCH_X87
6 6
7 #include "src/code-factory.h" 7 #include "src/code-factory.h"
8 #include "src/codegen.h" 8 #include "src/codegen.h"
9 #include "src/deoptimizer.h" 9 #include "src/deoptimizer.h"
10 #include "src/full-codegen/full-codegen.h" 10 #include "src/full-codegen/full-codegen.h"
(...skipping 783 matching lines...) Expand 10 before | Expand all | Expand 10 after
794 __ Pop(esi); 794 __ Pop(esi);
795 __ Push(ebx); 795 __ Push(ebx);
796 __ Push(esi); 796 __ Push(esi);
797 797
798 // Dispatch to the target bytecode. 798 // Dispatch to the target bytecode.
799 __ movzx_b(esi, Operand(kInterpreterBytecodeArrayRegister, 799 __ movzx_b(esi, Operand(kInterpreterBytecodeArrayRegister,
800 kInterpreterBytecodeOffsetRegister, times_1, 0)); 800 kInterpreterBytecodeOffsetRegister, times_1, 0));
801 __ mov(ebx, Operand(ebx, esi, times_pointer_size, 0)); 801 __ mov(ebx, Operand(ebx, esi, times_pointer_size, 0));
802 802
803 // Get the context from the frame. 803 // Get the context from the frame.
804 // TODO(rmcilroy): Update interpreter frame to expect current context at the
805 // context slot instead of the function context.
806 __ mov(kContextRegister, 804 __ mov(kContextRegister,
807 Operand(kInterpreterRegisterFileRegister, 805 Operand(kInterpreterRegisterFileRegister,
808 InterpreterFrameConstants::kContextFromRegisterPointer)); 806 InterpreterFrameConstants::kContextFromRegisterPointer));
809 807
810 // TODO(rmcilroy): Make dispatch table point to code entrys to avoid untagging 808 // TODO(rmcilroy): Make dispatch table point to code entrys to avoid untagging
811 // and header removal. 809 // and header removal.
812 __ add(ebx, Immediate(Code::kHeaderSize - kHeapObjectTag)); 810 __ add(ebx, Immediate(Code::kHeaderSize - kHeapObjectTag));
813 __ jmp(ebx); 811 __ jmp(ebx);
814 } 812 }
815 813
(...skipping 1729 matching lines...) Expand 10 before | Expand all | Expand 10 after
2545 2543
2546 __ bind(&ok); 2544 __ bind(&ok);
2547 __ ret(0); 2545 __ ret(0);
2548 } 2546 }
2549 2547
2550 #undef __ 2548 #undef __
2551 } // namespace internal 2549 } // namespace internal
2552 } // namespace v8 2550 } // namespace v8
2553 2551
2554 #endif // V8_TARGET_ARCH_X87 2552 #endif // V8_TARGET_ARCH_X87
OLDNEW
« no previous file with comments | « src/x64/builtins-x64.cc ('k') | test/cctest/interpreter/test-bytecode-generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698