Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Side by Side Diff: src/ia32/builtins-ia32.cc

Issue 1604923002: [Interpreter] Always store current context in the frames context slot. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@int_fix_block_context_scope
Patch Set: Rebase Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/interpreter-assembler.cc ('k') | src/interpreter/bytecode-array-builder.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_IA32 5 #if V8_TARGET_ARCH_IA32
6 6
7 #include "src/code-factory.h" 7 #include "src/code-factory.h"
8 #include "src/codegen.h" 8 #include "src/codegen.h"
9 #include "src/deoptimizer.h" 9 #include "src/deoptimizer.h"
10 #include "src/full-codegen/full-codegen.h" 10 #include "src/full-codegen/full-codegen.h"
(...skipping 782 matching lines...) Expand 10 before | Expand all | Expand 10 after
793 __ Pop(esi); 793 __ Pop(esi);
794 __ Push(ebx); 794 __ Push(ebx);
795 __ Push(esi); 795 __ Push(esi);
796 796
797 // Dispatch to the target bytecode. 797 // Dispatch to the target bytecode.
798 __ movzx_b(esi, Operand(kInterpreterBytecodeArrayRegister, 798 __ movzx_b(esi, Operand(kInterpreterBytecodeArrayRegister,
799 kInterpreterBytecodeOffsetRegister, times_1, 0)); 799 kInterpreterBytecodeOffsetRegister, times_1, 0));
800 __ mov(ebx, Operand(ebx, esi, times_pointer_size, 0)); 800 __ mov(ebx, Operand(ebx, esi, times_pointer_size, 0));
801 801
802 // Get the context from the frame. 802 // Get the context from the frame.
803 // TODO(rmcilroy): Update interpreter frame to expect current context at the
804 // context slot instead of the function context.
805 __ mov(kContextRegister, 803 __ mov(kContextRegister,
806 Operand(kInterpreterRegisterFileRegister, 804 Operand(kInterpreterRegisterFileRegister,
807 InterpreterFrameConstants::kContextFromRegisterPointer)); 805 InterpreterFrameConstants::kContextFromRegisterPointer));
808 806
809 // TODO(rmcilroy): Make dispatch table point to code entrys to avoid untagging 807 // TODO(rmcilroy): Make dispatch table point to code entrys to avoid untagging
810 // and header removal. 808 // and header removal.
811 __ add(ebx, Immediate(Code::kHeaderSize - kHeapObjectTag)); 809 __ add(ebx, Immediate(Code::kHeaderSize - kHeapObjectTag));
812 __ jmp(ebx); 810 __ jmp(ebx);
813 } 811 }
814 812
(...skipping 1728 matching lines...) Expand 10 before | Expand all | Expand 10 after
2543 2541
2544 __ bind(&ok); 2542 __ bind(&ok);
2545 __ ret(0); 2543 __ ret(0);
2546 } 2544 }
2547 2545
2548 #undef __ 2546 #undef __
2549 } // namespace internal 2547 } // namespace internal
2550 } // namespace v8 2548 } // namespace v8
2551 2549
2552 #endif // V8_TARGET_ARCH_IA32 2550 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/compiler/interpreter-assembler.cc ('k') | src/interpreter/bytecode-array-builder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698