Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/builder.dart

Issue 16049017: Fix https://code.google.com/p/dart/issues/detail?id=11117 by not inlining geenrative constructors a… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/language/inferrer_constructor3_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/ssa/builder.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/ssa/builder.dart (revision 23726)
+++ sdk/lib/_internal/compiler/implementation/ssa/builder.dart (working copy)
@@ -1260,6 +1260,13 @@
if (compiler.disableInlining) return false;
if (inliningStack.length > MAX_INLINING_DEPTH) return false;
+ // BUG(11136): The backend inferrer does not work when inlining
+ // these elements.
+ if (element.isGenerativeConstructor()
+ || element.isGenerativeConstructorBody()) {
+ return false;
+ }
+
// Ensure that [element] is an implementation element.
element = element.implementation;
FunctionElement function = element;
« no previous file with comments | « no previous file | tests/language/inferrer_constructor3_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698