Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/serviceworker/windowclient-navigate.html

Issue 1604893002: ServiceWorker: Rewrite windowclient-navigate.html test. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/http/tests/serviceworker/windowclient-navigate.html
diff --git a/third_party/WebKit/LayoutTests/http/tests/serviceworker/windowclient-navigate.html b/third_party/WebKit/LayoutTests/http/tests/serviceworker/windowclient-navigate.html
index 6249dad9196ff8f4e49192038163dd19ed7cc92a..0f44500b0c7766a1a01cd021da29482ba2614462 100644
--- a/third_party/WebKit/LayoutTests/http/tests/serviceworker/windowclient-navigate.html
+++ b/third_party/WebKit/LayoutTests/http/tests/serviceworker/windowclient-navigate.html
@@ -27,6 +27,7 @@ var test_list = [
];
var expected = [
+ 'TypeError', // in-scope-but-not-controlled (start from serviceworker)
location.origin + '/serviceworker/resources/blank.html',
location.origin + '/serviceworker/' + script_url,
'TypeError',
@@ -60,7 +61,7 @@ async_test(function(t) {
function on_message(e, port) {
var message = e.data;
- message == 'ready' || actual.push(message);
+ actual.push(message);
if (expected.length == actual.length) {
assert_array_equals(actual, expected);
service_worker_unregister_and_done(test, scope);

Powered by Google App Engine
This is Rietveld 408576698