Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 160483004: Keep track of the list of currently mounted volumes in C++-side VolumeManager. (Closed)

Created:
6 years, 10 months ago by kinaba
Modified:
6 years, 10 months ago
Reviewers:
mtomasz, hirono
CC:
chromium-reviews, rginda+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Keep track of the list of currently mounted volumes in C++-side VolumeManager. For the detail, refer the associated bug tracker. In short, I want to do this for implementing decision procedure for whether or not to mount zip archives based on originating profiles. Besides, I believe the new code is more clean--the old code that constructs the volume list every time FindVolumeById called is skewed. BUG=343038 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251013

Patch Set 1 #

Patch Set 2 : Fix tests #

Total comments: 4

Patch Set 3 : Review fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -95 lines) Patch
M chrome/browser/chromeos/extensions/file_manager/file_browser_private_apitest.cc View 1 2 chunks +7 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/file_manager/volume_manager.h View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/file_manager/volume_manager.cc View 1 2 6 chunks +83 lines, -62 lines 0 comments Download
M chrome/browser/chromeos/file_manager/volume_manager_unittest.cc View 1 6 chunks +29 lines, -19 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_browser/mount_test/test.js View 1 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
kinaba
ptal
6 years, 10 months ago (2014-02-13 01:47:59 UTC) #1
kinaba
On 2014/02/13 01:47:59, kinaba wrote: > ptal fixing tests. just a moment...
6 years, 10 months ago (2014-02-13 04:11:08 UTC) #2
kinaba
On 2014/02/13 04:11:08, kinaba wrote: > On 2014/02/13 01:47:59, kinaba wrote: > > ptal > ...
6 years, 10 months ago (2014-02-13 04:36:17 UTC) #3
hirono
lgtm with a nit! https://codereview.chromium.org/160483004/diff/80001/chrome/browser/chromeos/file_manager/volume_manager.cc File chrome/browser/chromeos/file_manager/volume_manager.cc (right): https://codereview.chromium.org/160483004/diff/80001/chrome/browser/chromeos/file_manager/volume_manager.cc#newcode234 chrome/browser/chromeos/file_manager/volume_manager.cc:234: bool success = RegisterDownloadsMountPoint(profile_, downloads); ...
6 years, 10 months ago (2014-02-13 05:09:05 UTC) #4
mtomasz
lgtm with a nit https://codereview.chromium.org/160483004/diff/80001/chrome/browser/chromeos/file_manager/volume_manager.cc File chrome/browser/chromeos/file_manager/volume_manager.cc (right): https://codereview.chromium.org/160483004/diff/80001/chrome/browser/chromeos/file_manager/volume_manager.cc#newcode239 chrome/browser/chromeos/file_manager/volume_manager.cc:239: false); nit: Can we add ...
6 years, 10 months ago (2014-02-13 05:22:50 UTC) #5
kinaba
https://codereview.chromium.org/160483004/diff/80001/chrome/browser/chromeos/file_manager/volume_manager.cc File chrome/browser/chromeos/file_manager/volume_manager.cc (right): https://codereview.chromium.org/160483004/diff/80001/chrome/browser/chromeos/file_manager/volume_manager.cc#newcode234 chrome/browser/chromeos/file_manager/volume_manager.cc:234: bool success = RegisterDownloadsMountPoint(profile_, downloads); On 2014/02/13 05:09:06, hirono ...
6 years, 10 months ago (2014-02-13 06:25:46 UTC) #6
kinaba
https://codereview.chromium.org/160483004/diff/80001/chrome/browser/chromeos/file_manager/volume_manager.cc File chrome/browser/chromeos/file_manager/volume_manager.cc (right): https://codereview.chromium.org/160483004/diff/80001/chrome/browser/chromeos/file_manager/volume_manager.cc#newcode239 chrome/browser/chromeos/file_manager/volume_manager.cc:239: false); On 2014/02/13 05:22:50, mtomasz wrote: > nit: Can ...
6 years, 10 months ago (2014-02-13 06:26:13 UTC) #7
kinaba
The CQ bit was checked by kinaba@chromium.org
6 years, 10 months ago (2014-02-13 06:27:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/160483004/170001
6 years, 10 months ago (2014-02-13 06:28:49 UTC) #9
commit-bot: I haz the power
6 years, 10 months ago (2014-02-13 15:14:01 UTC) #10
Message was sent while issue was closed. 
Change committed as 251013

Powered by Google App Engine
This is Rietveld 408576698