Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2335)

Unified Diff: content/renderer/render_widget.cc

Issue 16048003: Fix race between DPI and window size (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_widget.cc
diff --git a/content/renderer/render_widget.cc b/content/renderer/render_widget.cc
index 00908f2663b4eced7a2ea337abe45e013dfac1db..48d4e7c20241a3f22fd24e011d698254fb301fa7 100644
--- a/content/renderer/render_widget.cc
+++ b/content/renderer/render_widget.cc
@@ -337,7 +337,6 @@ bool RenderWidget::OnMessageReceived(const IPC::Message& message) {
IPC_MESSAGE_HANDLER(ViewMsg_SmoothScrollCompleted, OnSmoothScrollCompleted)
IPC_MESSAGE_HANDLER(ViewMsg_SetTextDirection, OnSetTextDirection)
IPC_MESSAGE_HANDLER(ViewMsg_Move_ACK, OnRequestMoveAck)
- IPC_MESSAGE_HANDLER(ViewMsg_ScreenInfoChanged, OnScreenInfoChanged)
IPC_MESSAGE_HANDLER(ViewMsg_UpdateScreenRects, OnUpdateScreenRects)
#if defined(OS_ANDROID)
IPC_MESSAGE_HANDLER(ViewMsg_ImeBatchStateChanged, OnImeBatchStateChanged)
@@ -462,14 +461,13 @@ void RenderWidget::OnCreatingNewAck() {
CompleteInit();
}
-void RenderWidget::OnResize(const gfx::Size& new_size,
- const gfx::Size& physical_backing_size,
- float overdraw_bottom_height,
- const gfx::Rect& resizer_rect,
- bool is_fullscreen) {
- Resize(new_size, physical_backing_size, overdraw_bottom_height, resizer_rect,
- is_fullscreen, SEND_RESIZE_ACK);
- size_browser_expects_ = new_size;
+void RenderWidget::OnResize(const ViewMsg_Resize_Params& params) {
+ screen_info_ = params.screen_info;
+ SetDeviceScaleFactor(screen_info_.deviceScaleFactor);
+ Resize(params.new_size, params.physical_backing_size,
+ params.overdraw_bottom_height, params.resizer_rect,
+ params.is_fullscreen, SEND_RESIZE_ACK);
+ size_browser_expects_ = params.new_size;
}
void RenderWidget::OnChangeResizeRect(const gfx::Rect& resizer_rect) {
@@ -1957,12 +1955,6 @@ void RenderWidget::OnSetTextDirection(WebTextDirection direction) {
webwidget_->setTextDirection(direction);
}
-void RenderWidget::OnScreenInfoChanged(
- const WebKit::WebScreenInfo& screen_info) {
- screen_info_ = screen_info;
- SetDeviceScaleFactor(screen_info.deviceScaleFactor);
-}
-
void RenderWidget::OnUpdateScreenRects(const gfx::Rect& view_screen_rect,
const gfx::Rect& window_screen_rect) {
view_screen_rect_ = view_screen_rect;

Powered by Google App Engine
This is Rietveld 408576698