third_party/WebKit/Source/core/editing/iterators/SimplifiedBackwardsTextIterator.h - Issue 1604783002: ALL-IN-ONE: Optimization to previousBoundary() and nextBoundary()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/iterators/SimplifiedBackwardsTextIterator.h

Issue 1604783002: ALL-IN-ONE: Optimization to previousBoundary() and nextBoundary() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@progressive_accumulator

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/editing/VisibleUnits.cpp ('K') | « third_party/WebKit/Source/core/editing/iterators/ProgressiveTextAccumulatorTest.cpp ('k') | third_party/WebKit/Source/core/editing/iterators/TextIterator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/iterators/SimplifiedBackwardsTextIterator.h

diff --git a/third_party/WebKit/Source/core/editing/iterators/SimplifiedBackwardsTextIterator.h b/third_party/WebKit/Source/core/editing/iterators/SimplifiedBackwardsTextIterator.h

index 58ad56a3987edd89b0934b376eca5d1942d5d107..86da46a3eb8b7a6407eed6b2953e73f7837a5974 100644

--- a/third_party/WebKit/Source/core/editing/iterators/SimplifiedBackwardsTextIterator.h

+++ b/third_party/WebKit/Source/core/editing/iterators/SimplifiedBackwardsTextIterator.h

@@ -43,6 +43,10 @@ template <typename Strategy>

class CORE_TEMPLATE_CLASS_EXPORT SimplifiedBackwardsTextIteratorAlgorithm {

STACK_ALLOCATED();

public:

+ using PositionType = PositionTemplate<Strategy>;

+ static const TextIteratorDirection direction = TextIteratorDirection::TextIteratorBackward;

SimplifiedBackwardsTextIteratorAlgorithm(const PositionTemplate<Strategy>& start, const PositionTemplate<Strategy>& end, TextIteratorBehaviorFlags = TextIteratorDefaultBehavior);

bool atEnd() const { return !m_positionNode || m_shouldStop; }