third_party/WebKit/Source/core/editing/PlainTextRange.cpp - Issue 1604783002: ALL-IN-ONE: Optimization to previousBoundary() and nextBoundary()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/PlainTextRange.cpp

Issue 1604783002: ALL-IN-ONE: Optimization to previousBoundary() and nextBoundary() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@progressive_accumulator

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/core.gypi ('k') | third_party/WebKit/Source/core/editing/VisibleUnits.cpp » ('j') | third_party/WebKit/Source/core/editing/VisibleUnits.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/PlainTextRange.cpp

diff --git a/third_party/WebKit/Source/core/editing/PlainTextRange.cpp b/third_party/WebKit/Source/core/editing/PlainTextRange.cpp

index d0b7331c88f13c3fc93344b61a51b3799831046f..db0432c8a9c45d14ee158e6d7517e5b4d6acbbeb 100644

--- a/third_party/WebKit/Source/core/editing/PlainTextRange.cpp

+++ b/third_party/WebKit/Source/core/editing/PlainTextRange.cpp

@@ -107,7 +107,7 @@ EphemeralRange PlainTextRange::createRangeFor(const ContainerNode& scope, GetRan

// FIXME: This is a workaround for the fact that the end of a run

// is often at the wrong position for emitted '\n's or if the

// layoutObject of the current node is a replaced element.

- if (len == 1 && (it.text().characterAt(0) == '\n' || it.isInsideAtomicInlineElement())) {

+ if (len == 1 && (it.characterAt(0) == '\n' || it.isInsideAtomicInlineElement())) {

it.advance();

if (!it.atEnd()) {

textRunEndPosition = it.startPositionInCurrentContainer();