src/arm/simulator-arm.cc - Issue 1604653006: Introduce BUILTIN_CALL_PAIR.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/simulator-arm.cc

Issue 1604653006: Introduce BUILTIN_CALL_PAIR. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Changes based on review comments. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/arm/simulator-arm.cc

diff --git a/src/arm/simulator-arm.cc b/src/arm/simulator-arm.cc

index 75a75ecd0ae7c66362c7ca77e3e05ab90366aa44..06c1bb9724e23ded9b413e6ff11b45b0b1d12ad4 100644

--- a/src/arm/simulator-arm.cc

+++ b/src/arm/simulator-arm.cc

@@ -1933,7 +1933,8 @@ void Simulator::SoftwareInterrupt(Instruction* instr) {

set_register(r0, arg0);

} else {

// builtin call.

- DCHECK(redirection->type() == ExternalReference::BUILTIN_CALL);

+ DCHECK(redirection->type() == ExternalReference::BUILTIN_CALL ||

+ redirection->type() == ExternalReference::BUILTIN_CALL_PAIR);

SimulatorRuntimeCall target =

reinterpret_cast<SimulatorRuntimeCall>(external);

if (::v8::internal::FLAG_trace_sim || !stack_aligned) {

« no previous file with comments | « no previous file | src/arm64/simulator-arm64.cc » ('j') | no next file with comments »