Introduce BUILTIN_CALL_PAIR.

src/assembler.cc

 // Copyright (c) 1994-2006 Sun Microsystems Inc.
 // All Rights Reserved.
 //
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 // - Redistributions of source code must retain the above copyright notice,
 // this list of conditions and the following disclaimer.
 //
@@ skipping 1011 matching lines @@
 ExternalReference::ExternalReference(Builtins::Name name, Isolate* isolate)
   : address_(isolate->builtins()->builtin_address(name)) {}
 
 
 ExternalReference::ExternalReference(Runtime::FunctionId id, Isolate* isolate)
     : ExternalReference(Runtime::FunctionForId(id), isolate) {}
 
 
 ExternalReference::ExternalReference(const Runtime::Function* f,
                                      Isolate* isolate)
-    : address_(Redirect(isolate, f->entry, f->result_size == 3
-                                               ? BUILTIN_CALL_TRIPLE
-                                               : BUILTIN_CALL)) {}
+    : address_(Redirect(
+          isolate, f->entry,
+          f->result_size == 3
+              ? BUILTIN_CALL_TRIPLE
+              : (f->result_size == 2 ? BUILTIN_CALL_PAIR : BUILTIN_CALL))) {}

[rmcilroy, 2016/01/21 12:15:33]

Please pull this logic out into a helper function rather than nesting tertiary
operators.

[MTBrandyberry, 2016/01/21 16:00:32]

Done.

 
 
 ExternalReference ExternalReference::isolate_address(Isolate* isolate) {
   return ExternalReference(isolate);
 }
 
 
 ExternalReference::ExternalReference(StatsCounter* counter)
   : address_(reinterpret_cast<Address>(counter->GetInternalPointer())) {}
 
@@ skipping 807 matching lines @@
 
 
 void Assembler::DataAlign(int m) {
   DCHECK(m >= 2 && base::bits::IsPowerOfTwo32(m));
   while ((pc_offset() & (m - 1)) != 0) {
     db(0);
   }
 }
 }  // namespace internal
 }  // namespace v8