Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1604653002:
ui/ozone: Fix up VGEM header path (Closed)
|
Created:
4 years, 11 months ago by vignatti (out of this project) Modified:
4 years, 11 months ago CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionui/ozone: Fix up VGEM header path
BUG=475633
Committed: https://crrev.com/67157bb7ef98f47907fd195ce64e6bd735bc1617
Cr-Commit-Position: refs/heads/master@{#370676}
Patch Set 1 #
Total comments: 2
Patch Set 2 : place include file in the alphabetical order #Messages
Total messages: 17 (8 generated)
Description was changed from ========== ui/ozone: Fix up VGEM header path BUG=475633 ========== to ========== ui/ozone: Fix up VGEM header path BUG=475633 ==========
tiago.vignatti@intel.com changed reviewers: + dongseong.hwang@intel.com
PTAL Dongseong.
On 2016/01/18 23:18:56, vignatti wrote: > PTAL Dongseong. Sorry, I cannot make right judgement. Both <vgem_drm.h> and <libdrm/vgem_drm.h> work, because gbm.gypi depends on '../../build/linux/system.gyp:libdrm'. Why does it bother you? "#include <drm.h>" here and there makes me reluctant to say lgtm. How about asking spang?
spang@chromium.org changed reviewers: + spang@chromium.org
lgtm
tiago.vignatti@intel.com changed reviewers: + dnicoara@chromium.org
Daniel, PTAL.
lgtm % ordering https://codereview.chromium.org/1604653002/diff/1/ui/ozone/platform/drm/commo... File ui/ozone/platform/drm/common/client_native_pixmap_vgem.cc (right): https://codereview.chromium.org/1604653002/diff/1/ui/ozone/platform/drm/commo... ui/ozone/platform/drm/common/client_native_pixmap_vgem.cc:10: #include <libdrm/vgem_drm.h> please fix ordering
https://codereview.chromium.org/1604653002/diff/1/ui/ozone/platform/drm/commo... File ui/ozone/platform/drm/common/client_native_pixmap_vgem.cc (right): https://codereview.chromium.org/1604653002/diff/1/ui/ozone/platform/drm/commo... ui/ozone/platform/drm/common/client_native_pixmap_vgem.cc:10: #include <libdrm/vgem_drm.h> On 2016/01/20 22:43:01, dnicoara wrote: > please fix ordering Done.
The CQ bit was checked by tiago.vignatti@intel.com
The patchset sent to the CQ was uploaded after l-g-t-m from dnicoara@chromium.org, dongseong.hwang@intel.com, spang@chromium.org Link to the patchset: https://codereview.chromium.org/1604653002/#ps20001 (title: "place include file in the alphabetical order")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1604653002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1604653002/20001
Message was sent while issue was closed.
Description was changed from ========== ui/ozone: Fix up VGEM header path BUG=475633 ========== to ========== ui/ozone: Fix up VGEM header path BUG=475633 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== ui/ozone: Fix up VGEM header path BUG=475633 ========== to ========== ui/ozone: Fix up VGEM header path BUG=475633 Committed: https://crrev.com/67157bb7ef98f47907fd195ce64e6bd735bc1617 Cr-Commit-Position: refs/heads/master@{#370676} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/67157bb7ef98f47907fd195ce64e6bd735bc1617 Cr-Commit-Position: refs/heads/master@{#370676} |
