Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1604603002: [wasm] Use TruncationMode::kJavaScript when coming from asm.js. (Closed)

Created:
4 years, 11 months ago by titzer
Modified:
4 years, 11 months ago
Reviewers:
ahaas
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Use TruncationMode::kJavaScript when coming from asm.js. R=ahaas@chromium.org BUG= Committed: https://crrev.com/6d38478849eb91099848a67fa2f9769dca82118a Cr-Commit-Position: refs/heads/master@{#33381}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M src/compiler/wasm-compiler.cc View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
titzer
4 years, 11 months ago (2016-01-18 18:46:23 UTC) #1
ahaas
lgtm
4 years, 11 months ago (2016-01-19 08:11:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1604603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1604603002/1
4 years, 11 months ago (2016-01-19 08:23:43 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-19 08:28:52 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-19 08:29:31 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/6d38478849eb91099848a67fa2f9769dca82118a
Cr-Commit-Position: refs/heads/master@{#33381}

Powered by Google App Engine
This is Rietveld 408576698