Issue 160458: Fixes possible crash in bookmark menus. Specifically if you had a menu...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 160458: Fixes possible crash in bookmark menus. Specifically if you had a menu... (Closed)

Created:
11 years, 4 months ago by sky

Modified:
9 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fixes possible crash in bookmark menus. Specifically if you had a menu showing and brought up the context menu and clicked a separator we would do the wrong thing. We would try to show the first menu again, without cancelling out of the inner loop, which would most likely result in a crash. The right thing to do in this case is not close the context menu (this behavior can be seen in windows as well). BUG=17862 TEST=see bug, but also covered by ui test now. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22180

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+87 lines, -3 lines)			Patch
M	chrome/browser/views/bookmark_bar_view_test.cc	View	1 chunk	+77 lines, -0 lines	0 comments	Download
M	views/controls/menu/chrome_menu.h	View	2 chunks	+7 lines, -2 lines	0 comments	Download
M	views/controls/menu/chrome_menu.cc	View	2 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages