Add "Get themes" button to the prefs.

Add "Get themes" button to the prefs.

BUG=none
TEST=you get a button "get themes" that takes you to the theme gallery.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22153

[pink (ping after 24hrs), 2009-07-31 14:24:25]

LGTM

http://codereview.chromium.org/160455/diff/1/2
File chrome/app/nibs/Preferences.xib (right):

http://codereview.chromium.org/160455/diff/1/2#newcode1711
Line 1711: <string key="NSContents">Get Themes</string>
Should this be 'Get Themes…'?

http://codereview.chromium.org/160455/diff/1/3
File chrome/browser/cocoa/preferences_window_controller.mm (right):

http://codereview.chromium.org/160455/diff/1/3#newcode648
Line 648: browser = Browser::Create(profile_);
it bugs me on a larger level that we have code sprinkled all over that mimics
this code (incorrectly, in the case of browser_init). Can we add a static method
to BrowserList to create a window with the appropriate type that re-uses an open
window first, but creates it correctly if not?

[Avi (use Gerrit), 2009-07-31 14:29:39]

http://codereview.chromium.org/160455/diff/1/2
File chrome/app/nibs/Preferences.xib (right):

http://codereview.chromium.org/160455/diff/1/2#newcode1711
Line 1711: <string key="NSContents">Get Themes</string>
On 2009/07/31 14:24:25, pink wrote:
> Should this be 'Get Themes…'? 

An ellipsis means that more information is going to be needed to carry out the
task, and that a dialog will pop up. This calls for more like a blue hyperlink
kinda thing but for now I wanted to get the basics in.

http://codereview.chromium.org/160455/diff/1/3
File chrome/browser/cocoa/preferences_window_controller.mm (right):

http://codereview.chromium.org/160455/diff/1/3#newcode648
Line 648: browser = Browser::Create(profile_);
Hm. This is code swiped straight from the Windows version. I've not seen this
code all over the place; if you want to put in a function to do that, if you
know all the places that call this then go ahead.

[Avi (use Gerrit), 2009-07-31 14:48:57]

... for the win