Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 160455: Add "Get themes" button to the prefs. (Closed)

Created:
11 years, 4 months ago by Avi (use Gerrit)
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, John Grabowski, Ben Goodger (Google)
Visibility:
Public.

Description

Add "Get themes" button to the prefs. BUG=none TEST=you get a button "get themes" that takes you to the theme gallery. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22153

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -5 lines) Patch
M chrome/app/nibs/Preferences.xib View 1 12 chunks +56 lines, -5 lines 0 comments Download
M chrome/browser/cocoa/preferences_window_controller.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/cocoa/preferences_window_controller.mm View 2 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Avi (use Gerrit)
11 years, 4 months ago (2009-07-31 14:15:29 UTC) #1
pink (ping after 24hrs)
LGTM http://codereview.chromium.org/160455/diff/1/2 File chrome/app/nibs/Preferences.xib (right): http://codereview.chromium.org/160455/diff/1/2#newcode1711 Line 1711: <string key="NSContents">Get Themes</string> Should this be 'Get ...
11 years, 4 months ago (2009-07-31 14:24:25 UTC) #2
Avi (use Gerrit)
http://codereview.chromium.org/160455/diff/1/2 File chrome/app/nibs/Preferences.xib (right): http://codereview.chromium.org/160455/diff/1/2#newcode1711 Line 1711: <string key="NSContents">Get Themes</string> On 2009/07/31 14:24:25, pink wrote: ...
11 years, 4 months ago (2009-07-31 14:29:39 UTC) #3
Avi (use Gerrit)
11 years, 4 months ago (2009-07-31 14:48:57 UTC) #4
... for the win

Powered by Google App Engine
This is Rietveld 408576698