Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: src/compiler.cc

Issue 1604543002: [compiler] Remove CodeStub from CompilationInfo (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Review feedback Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler.h ('k') | src/compiler/code-stub-assembler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler.cc
diff --git a/src/compiler.cc b/src/compiler.cc
index 92d7728b599708761bf7e58f209f916f46680c4b..fd30ed955a64cbdccc67c15ca755df99858f3206 100644
--- a/src/compiler.cc
+++ b/src/compiler.cc
@@ -110,8 +110,8 @@ bool CompilationInfo::has_scope() const {
CompilationInfo::CompilationInfo(ParseInfo* parse_info)
- : CompilationInfo(parse_info, nullptr, nullptr, BASE, parse_info->isolate(),
- parse_info->zone()) {
+ : CompilationInfo(parse_info, nullptr, Code::ComputeFlags(Code::FUNCTION),
+ BASE, parse_info->isolate(), parse_info->zone()) {
// Compiling for the snapshot typically results in different code than
// compiling later on. This means that code recompiled with deoptimization
// support won't be "equivalent" (as defined by SharedFunctionInfo::
@@ -138,23 +138,17 @@ CompilationInfo::CompilationInfo(ParseInfo* parse_info)
}
-CompilationInfo::CompilationInfo(CodeStub* stub, Isolate* isolate, Zone* zone)
- : CompilationInfo(nullptr, stub, CodeStub::MajorName(stub->MajorKey()),
- STUB, isolate, zone) {}
-
CompilationInfo::CompilationInfo(const char* debug_name, Isolate* isolate,
- Zone* zone)
- : CompilationInfo(nullptr, nullptr, debug_name, STUB, isolate, zone) {
- set_output_code_kind(Code::STUB);
-}
+ Zone* zone, Code::Flags code_flags)
+ : CompilationInfo(nullptr, debug_name, code_flags, STUB, isolate, zone) {}
-CompilationInfo::CompilationInfo(ParseInfo* parse_info, CodeStub* code_stub,
- const char* debug_name, Mode mode,
+CompilationInfo::CompilationInfo(ParseInfo* parse_info, const char* debug_name,
+ Code::Flags code_flags, Mode mode,
Isolate* isolate, Zone* zone)
: parse_info_(parse_info),
isolate_(isolate),
flags_(0),
- code_stub_(code_stub),
+ code_flags_(code_flags),
mode_(mode),
osr_ast_id_(BailoutId::None()),
zone_(zone),
@@ -168,19 +162,7 @@ CompilationInfo::CompilationInfo(ParseInfo* parse_info, CodeStub* code_stub,
parameter_count_(0),
optimization_id_(-1),
osr_expr_stack_height_(0),
- debug_name_(debug_name) {
- // Parameter count is number of stack parameters.
- if (code_stub_ != NULL) {
- CodeStubDescriptor descriptor(code_stub_);
- parameter_count_ = descriptor.GetStackParameterCount();
- if (descriptor.function_mode() == NOT_JS_FUNCTION_STUB_MODE) {
- parameter_count_--;
- }
- set_output_code_kind(code_stub->GetCodeKind());
- } else {
- set_output_code_kind(Code::FUNCTION);
- }
-}
+ debug_name_(debug_name) {}
CompilationInfo::~CompilationInfo() {
« no previous file with comments | « src/compiler.h ('k') | src/compiler/code-stub-assembler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698