Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: src/compiler/fast-accessor-assembler.cc

Issue 1604543002: [compiler] Remove CodeStub from CompilationInfo (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Review feedback Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/code-stub-assembler.cc ('k') | src/compiler/interpreter-assembler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/fast-accessor-assembler.h" 5 #include "src/compiler/fast-accessor-assembler.h"
6 6
7 #include "src/base/logging.h" 7 #include "src/base/logging.h"
8 #include "src/compiler/graph.h" 8 #include "src/compiler/graph.h"
9 #include "src/compiler/linkage.h" 9 #include "src/compiler/linkage.h"
10 #include "src/compiler/pipeline.h" 10 #include "src/compiler/pipeline.h"
(...skipping 158 matching lines...) Expand 10 before | Expand all | Expand 10 after
169 169
170 MaybeHandle<Code> FastAccessorAssembler::Build() { 170 MaybeHandle<Code> FastAccessorAssembler::Build() {
171 CHECK_EQ(kBuilding, state_); 171 CHECK_EQ(kBuilding, state_);
172 172
173 // Cleanup: We no longer need this. 173 // Cleanup: We no longer need this.
174 nodes_.clear(); 174 nodes_.clear();
175 labels_.clear(); 175 labels_.clear();
176 176
177 // Export the schedule and call the compiler. 177 // Export the schedule and call the compiler.
178 Schedule* schedule = assembler_->Export(); 178 Schedule* schedule = assembler_->Export();
179 Code::Flags flags = Code::ComputeFlags(Code::STUB);
179 MaybeHandle<Code> code = Pipeline::GenerateCodeForCodeStub( 180 MaybeHandle<Code> code = Pipeline::GenerateCodeForCodeStub(
180 assembler_->isolate(), assembler_->call_descriptor(), assembler_->graph(), 181 assembler_->isolate(), assembler_->call_descriptor(), assembler_->graph(),
181 schedule, Code::STUB, "FastAccessorAssembler"); 182 schedule, flags, "FastAccessorAssembler");
182 183
183 // Update state & return. 184 // Update state & return.
184 state_ = !code.is_null() ? kBuilt : kError; 185 state_ = !code.is_null() ? kBuilt : kError;
185 return code; 186 return code;
186 } 187 }
187 188
188 189
189 FastAccessorAssembler::ValueId FastAccessorAssembler::FromRaw(Node* node) { 190 FastAccessorAssembler::ValueId FastAccessorAssembler::FromRaw(Node* node) {
190 nodes_.push_back(node); 191 nodes_.push_back(node);
191 ValueId value = {nodes_.size() - 1}; 192 ValueId value = {nodes_.size() - 1};
(...skipping 19 matching lines...) Expand all
211 RawMachineLabel* FastAccessorAssembler::FromId(LabelId label) const { 212 RawMachineLabel* FastAccessorAssembler::FromId(LabelId label) const {
212 CHECK_LT(label.label_id, labels_.size()); 213 CHECK_LT(label.label_id, labels_.size());
213 CHECK_NOT_NULL(labels_.at(label.label_id)); 214 CHECK_NOT_NULL(labels_.at(label.label_id));
214 return labels_.at(label.label_id); 215 return labels_.at(label.label_id);
215 } 216 }
216 217
217 218
218 } // namespace compiler 219 } // namespace compiler
219 } // namespace internal 220 } // namespace internal
220 } // namespace v8 221 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/code-stub-assembler.cc ('k') | src/compiler/interpreter-assembler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698