Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Unified Diff: trunk/src/chrome/renderer/translate/translate_helper_metrics.h

Issue 16045007: Revert 202427 "Translate: adopt html lang attribute if valid val..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/renderer/translate/translate_helper_metrics.h
===================================================================
--- trunk/src/chrome/renderer/translate/translate_helper_metrics.h (revision 202442)
+++ trunk/src/chrome/renderer/translate/translate_helper_metrics.h (working copy)
@@ -16,7 +16,6 @@
enum MetricsNameIndex {
UMA_LANGUAGE_DETECTION,
UMA_CONTENT_LANGUAGE,
- UMA_HTML_LANG,
UMA_LANGUAGE_VERIFICATION,
UMA_TIME_TO_BE_READY,
UMA_TIME_TO_LOAD,
@@ -28,11 +27,11 @@
// A page may provide a Content-Language HTTP header or a META tag.
// TranslateHelper checks if a server provides a valid Content-Language.
-enum LanguageCheckType {
- LANGUAGE_NOT_PROVIDED,
- LANGUAGE_VALID,
- LANGUAGE_INVALID,
- LANGUAGE_MAX,
+enum ContentLanguageType {
+ CONTENT_LANGUAGE_NOT_PROVIDED,
+ CONTENT_LANGUAGE_VALID,
+ CONTENT_LANGUAGE_INVALID,
+ CONTENT_LANGUAGE_MAX,
};
// When a valid Content-Language is provided, TranslateHelper checks if a
@@ -55,19 +54,12 @@
};
// Called after TranslateHelper verifies a server providing Content-Language
-// header. |provided_code| contains a Content-Language header value which a
+// header. |provided_code| contains a Content-Language header value which
// server provides. It can be empty string when a server doesn't provide it.
// |revised_code| is a value modified by format error corrector.
void ReportContentLanguage(const std::string& provided_code,
const std::string& revised_code);
-// Called after TranslateHelper verifies a page providing html lang attribute.
-// |provided_code| contains a html lang attribute which a page provides. It can
-// be empty string when a page doesn't provide it. |revised_code| is a value
-// modified by format error corrector.
-void ReportHtmlLang(const std::string& provided_code,
- const std::string& revised_code);
-
// Called when CLD verifies Content-Language header.
void ReportLanguageVerification(LanguageVerificationType type);

Powered by Google App Engine
This is Rietveld 408576698