Migrate auto_tests about proxy configuration to browser_tests.

Migrate auto_tests about proxy configuration to browser_tests.

At the same time this
- removes a lot of unnecessary code testing_automation_provider* and pyauto,
- removes the dependency of testing_automation_provider* on ProxyConfigServiceImpl.

BUG=234982
TEST=New browser_tests. Ran pyauto test testCachedCredentialsAddUser locally.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202849

[pneubeck (no reviews), 2013-05-27 12:50:46]

Hi there,
please review according to OWNER-ship:

craigdh:
  chrome/test/

jam:
  chrome/browser/automation/

dbeam:
  chrome/browser/ui/webui/options/

Thanks!

[jam, 2013-05-28 14:28:52]

On 2013/05/27 12:50:46, pneubeck wrote:
> Hi there,
> please review according to OWNER-ship:
> 
> jam:
>   chrome/browser/automation/
lgtm

[craigdh, 2013-05-28 16:42:52]

lgtm.

[Dan Beam, 2013-05-28 22:45:26]

lgtm w/nits, I'm also not super versed on the internals of what you're
testing...

https://codereview.chromium.org/16045005/diff/11001/chrome/browser/ui/webui/o...
File chrome/browser/ui/webui/options/preferences_browsertest.cc (right):

https://codereview.chromium.org/16045005/diff/11001/chrome/browser/ui/webui/o...
chrome/browser/ui/webui/options/preferences_browsertest.cc:340: << "   
Preferences.set" << type.c_str() << "Pref("
is there any reason you need .c_str()?  std::string should work fine here I'd
think...

https://codereview.chromium.org/16045005/diff/11001/chrome/browser/ui/webui/o...
chrome/browser/ui/webui/options/preferences_browsertest.cc:340: << "   
Preferences.set" << type.c_str() << "Pref("
<< "  Preferences.set" << type.c_str() << "Pref("
    ^^ (fix indent)

https://codereview.chromium.org/16045005/diff/11001/chrome/browser/ui/webui/o...
chrome/browser/ui/webui/options/preferences_browsertest.cc:343: << "      " <<
*commit_ptr << ");});";
           << "      " << *commit_ptr << ");"
           << "});";

https://codereview.chromium.org/16045005/diff/11001/chrome/browser/ui/webui/o...
chrome/browser/ui/webui/options/preferences_browsertest.cc:846: 
nit: remove \n

https://codereview.chromium.org/16045005/diff/11001/chrome/browser/ui/webui/o...
File chrome/browser/ui/webui/options/preferences_browsertest.h (right):

https://codereview.chromium.org/16045005/diff/11001/chrome/browser/ui/webui/o...
chrome/browser/ui/webui/options/preferences_browsertest.h:126: // backend.
// and commits the change to the C++ if |commit| is true.

[pneubeck (no reviews), 2013-05-29 08:41:02]

https://codereview.chromium.org/16045005/diff/11001/chrome/browser/ui/webui/o...
File chrome/browser/ui/webui/options/preferences_browsertest.cc (right):

https://codereview.chromium.org/16045005/diff/11001/chrome/browser/ui/webui/o...
chrome/browser/ui/webui/options/preferences_browsertest.cc:340: << "   
Preferences.set" << type.c_str() << "Pref("
On 2013/05/28 22:45:27, Dan Beam wrote:
> is there any reason you need .c_str()?  std::string should work fine here I'd
> think...

Done.

https://codereview.chromium.org/16045005/diff/11001/chrome/browser/ui/webui/o...
chrome/browser/ui/webui/options/preferences_browsertest.cc:340: << "   
Preferences.set" << type.c_str() << "Pref("
On 2013/05/28 22:45:27, Dan Beam wrote:
> << "  Preferences.set" << type.c_str() << "Pref("
>     ^^ (fix indent)

Done.

https://codereview.chromium.org/16045005/diff/11001/chrome/browser/ui/webui/o...
chrome/browser/ui/webui/options/preferences_browsertest.cc:343: << "      " <<
*commit_ptr << ");});";
On 2013/05/28 22:45:27, Dan Beam wrote:
>            << "      " << *commit_ptr << ");"
>            << "});";

Done.

https://codereview.chromium.org/16045005/diff/11001/chrome/browser/ui/webui/o...
File chrome/browser/ui/webui/options/preferences_browsertest.h (right):

https://codereview.chromium.org/16045005/diff/11001/chrome/browser/ui/webui/o...
chrome/browser/ui/webui/options/preferences_browsertest.h:126: // backend.
On 2013/05/28 22:45:27, Dan Beam wrote:
> // and commits the change to the C++ if |commit| is true.

Done.

[commit-bot: I haz the power, 2013-05-29 08:41:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pneubeck@chromium.org/16045005/20001

[commit-bot: I haz the power, 2013-05-29 11:49:11]

Change committed as 202849