Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 16045003: Make editing/undo/undo-after-event-edited.html stable (Closed)

Created:
7 years, 6 months ago by yosin_UTC9
Modified:
7 years, 6 months ago
CC:
blink-reviews, eae+blinkwatch
Visibility:
Public.

Description

This patch changes a test script, undo-after-event-edited.html, stable, by executing JavaScript after document finished loading. When calling Range.extractContents() for selection selected whole document w/o body, SimplifiedBackwardsTextIterator creates Range object with DocumentType which is illegal argument for Range construction. BUG=242444 R=ojan@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151633

Patch Set 1 #

Patch Set 2 : 2013-06-03T16:54 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/editing/undo/undo-after-event-edited.html View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
yosin_UTC9
Could you review this patch? Thanks in advance.
7 years, 6 months ago (2013-05-27 10:04:21 UTC) #1
ojan
I think SimplifiedBackwardsTextIterator should be fixed to not trying to create a Range with a ...
7 years, 6 months ago (2013-05-31 20:49:50 UTC) #2
yosin_UTC9
On 2013/05/31 20:49:50, ojan wrote: > I think SimplifiedBackwardsTextIterator should be fixed to not trying ...
7 years, 6 months ago (2013-06-03 01:37:59 UTC) #3
ojan
lgtm Got it. Makes sense.
7 years, 6 months ago (2013-06-03 07:17:32 UTC) #4
yosin_UTC9
7 years, 6 months ago (2013-06-03 07:56:01 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r151633 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698