Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 160443004: Remove web page replay based pyauto tests. (Closed)

Created:
6 years, 10 months ago by tonyg
Modified:
6 years, 10 months ago
Reviewers:
craigdh, dtu, qyearsley, slamm
CC:
chromium-reviews, dennis_jeffrey, chromium-apps-reviews_chromium.org, anantha, dyu1, extensions-reviews_chromium.org
Visibility:
Public.

Description

Remove web page replay based pyauto tests. This is in preparation for moving webpagereplay.py into Telemetry. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250953

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1540 lines) Patch
M chrome/test/functional/PYAUTO_TESTS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/functional/perf.py View 2 chunks +0 lines, -92 lines 0 comments Download
M chrome/test/functional/perf/endure_result_parser.py View 2 chunks +3 lines, -20 lines 0 comments Download
M chrome/test/functional/perf_endure.py View 9 chunks +0 lines, -622 lines 0 comments Download
D tools/page_cycler/webpagereplay/README View 1 chunk +0 lines, -15 lines 0 comments Download
D tools/page_cycler/webpagereplay/extension/background.html View 1 chunk +0 lines, -2 lines 0 comments Download
D tools/page_cycler/webpagereplay/extension/background.js View 1 chunk +0 lines, -328 lines 4 comments Download
D tools/page_cycler/webpagereplay/extension/content.js View 1 chunk +0 lines, -14 lines 0 comments Download
D tools/page_cycler/webpagereplay/extension/manifest.json View 1 chunk +0 lines, -29 lines 0 comments Download
D tools/page_cycler/webpagereplay/extension/page_cycler.js View 1 chunk +0 lines, -54 lines 0 comments Download
D tools/page_cycler/webpagereplay/extension/start.js View 1 chunk +0 lines, -88 lines 0 comments Download
D tools/page_cycler/webpagereplay/start.html View 1 chunk +0 lines, -26 lines 0 comments Download
D tools/page_cycler/webpagereplay/start.js View 1 chunk +0 lines, -123 lines 0 comments Download
D tools/page_cycler/webpagereplay/tests/2012Q2.js View 1 chunk +0 lines, -77 lines 0 comments Download
D tools/page_cycler/webpagereplay/tests/2012Q3.js View 1 chunk +0 lines, -49 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
tonyg
https://codereview.chromium.org/160443004/diff/1/tools/page_cycler/webpagereplay/extension/background.js File tools/page_cycler/webpagereplay/extension/background.js (left): https://codereview.chromium.org/160443004/diff/1/tools/page_cycler/webpagereplay/extension/background.js#oldcode18 tools/page_cycler/webpagereplay/extension/background.js:18: var kConnectCount = "tcp.connect"; I'd really like to see ...
6 years, 10 months ago (2014-02-12 18:01:19 UTC) #1
slamm
https://codereview.chromium.org/160443004/diff/1/tools/page_cycler/webpagereplay/extension/background.js File tools/page_cycler/webpagereplay/extension/background.js (left): https://codereview.chromium.org/160443004/diff/1/tools/page_cycler/webpagereplay/extension/background.js#oldcode18 tools/page_cycler/webpagereplay/extension/background.js:18: var kConnectCount = "tcp.connect"; On 2014/02/12 18:01:20, tonyg wrote: ...
6 years, 10 months ago (2014-02-12 18:37:31 UTC) #2
craigdh
functional/* lgtm.
6 years, 10 months ago (2014-02-12 18:44:27 UTC) #3
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 10 months ago (2014-02-13 00:35:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/160443004/1
6 years, 10 months ago (2014-02-13 00:38:43 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-13 02:40:11 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=263150
6 years, 10 months ago (2014-02-13 02:40:12 UTC) #7
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 10 months ago (2014-02-13 03:35:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/160443004/1
6 years, 10 months ago (2014-02-13 03:37:38 UTC) #9
commit-bot: I haz the power
6 years, 10 months ago (2014-02-13 04:53:52 UTC) #10
Message was sent while issue was closed. 
Change committed as 250953

Powered by Google App Engine
This is Rietveld 408576698