Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 1604313002: Make GrGLProgramBuilder a local stack variable in CreateProgram (Closed)

Created:
4 years, 11 months ago by egdaniel
Modified:
4 years, 11 months ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 1 chunk +6 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
egdaniel
4 years, 11 months ago (2016-01-20 15:42:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1604313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1604313002/1
4 years, 11 months ago (2016-01-20 15:43:14 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 11 months ago (2016-01-20 15:43:15 UTC) #6
joshualitt
On 2016/01/20 15:43:15, commit-bot: I haz the power wrote: > Note for Reviewers: > The ...
4 years, 11 months ago (2016-01-20 15:51:04 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-20 15:53:53 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c1e710140b652509822a42872c4d4dd058393582

Powered by Google App Engine
This is Rietveld 408576698