Issue 1604303002: Update libjingle GYP+GN for talk/media move.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1604303002: Update libjingle GYP+GN for talk/media move. (Closed)

Created:
4 years, 11 months ago by kjellander_chromium

Modified:
4 years, 10 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
http://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Update libjingle GYP+GN for talk/media move. This CL is needed for the changes about to be performed in https://codereview.webrtc.org/1587193006/ It needs to be patched into the CL rolling the WebRTC+libjingle revision past that commit. The changes in this CL has been incorporated in the roll CL of https://codereview.chromium.org/1669023004/ instead. BUG=webrtc:5420 TESTED=Manually patched src/third_party/webrtc and src/third_party/libjingle/source/Talk and successfully compiled the libpeerconnection target.

Patch Set 1 : #

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+126 lines, -126 lines)			Patch
	M	third_party/libjingle/BUILD.gn	View		4 chunks	+54 lines, -54 lines	0 comments	Download
	M	third_party/libjingle/libjingle.gyp	View		5 chunks	+72 lines, -72 lines	0 comments	Download

Messages

Total messages: 2 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

kjellander_chromium

4 years, 10 months ago (2016-02-05 09:15:35 UTC) #2

Description was changed from

==========
Update libjingle GYP+GN for talk/media move.

This CL is needed for the changes about to be performed in
https://codereview.webrtc.org/1587193006/
It needs to be patched into the CL rolling the WebRTC+libjingle
revision past that commit.

BUG=webrtc:5420
TESTED=Manually patched src/third_party/webrtc and
src/third_party/libjingle/source/Talk
and successfully compiled the libpeerconnection target.
==========

to

==========
Update libjingle GYP+GN for talk/media move.

This CL is needed for the changes about to be performed in
https://codereview.webrtc.org/1587193006/
It needs to be patched into the CL rolling the WebRTC+libjingle
revision past that commit.

The changes in this CL has been incorporated in the roll CL of
https://codereview.chromium.org/1669023004/ instead.

BUG=webrtc:5420
TESTED=Manually patched src/third_party/webrtc and
src/third_party/libjingle/source/Talk
and successfully compiled the libpeerconnection target.
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages