Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1384)

Unified Diff: webkit/browser/fileapi/file_system_mount_point_provider.h

Issue 16043006: Rename FileSystemMountPointProvider::ValidateFileSystemRoot to OpenFileSystem (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/browser/fileapi/file_system_mount_point_provider.h
diff --git a/webkit/browser/fileapi/file_system_mount_point_provider.h b/webkit/browser/fileapi/file_system_mount_point_provider.h
index 51062eed751a95437dc5e0ef0624621183bda359..32219bfc92263421fcbd216cc1d0300d152b0b15 100644
--- a/webkit/browser/fileapi/file_system_mount_point_provider.h
+++ b/webkit/browser/fileapi/file_system_mount_point_provider.h
@@ -12,6 +12,7 @@
#include "base/files/file_path.h"
#include "base/memory/scoped_ptr.h"
#include "base/platform_file.h"
+#include "webkit/browser/fileapi/open_file_system_mode.h"
#include "webkit/fileapi/file_permission_policy.h"
#include "webkit/fileapi/file_system_types.h"
#include "webkit/storage/webkit_storage_export.h"
@@ -40,9 +41,9 @@ class RemoteFileSystemProxyInterface;
//
class WEBKIT_STORAGE_EXPORT FileSystemMountPointProvider {
public:
- // Callback for ValidateFileSystemRoot.
+ // Callback for OpenFileSystem.
typedef base::Callback<void(base::PlatformFileError error)>
- ValidateFileSystemCallback;
+ OpenFileSystemCallback;
typedef base::Callback<void(base::PlatformFileError error)>
DeleteFileSystemCallback;
virtual ~FileSystemMountPointProvider() {}
@@ -51,16 +52,17 @@ class WEBKIT_STORAGE_EXPORT FileSystemMountPointProvider {
// One mount point provider may be able to handle multiple filesystem types.
virtual bool CanHandleType(FileSystemType type) const = 0;
- // Validates the filesystem for the given |origin_url| and |type|.
+ // Initializes the filesystem for the given |origin_url| and |type|.
// This verifies if it is allowed to request (or create) the filesystem
// and if it can access (or create) the root directory of the mount point.
- // If |create| is true this may also create the root directory for
+ // If |mode| is CREATE_IF_NONEXISTENT calling this may also create
+ // the root directory (and/or related database entries etc) for
// the filesystem if it doesn't exist.
- virtual void ValidateFileSystemRoot(
+ virtual void OpenFileSystem(
const GURL& origin_url,
FileSystemType type,
- bool create,
- const ValidateFileSystemCallback& callback) = 0;
+ OpenFileSystemMode mode,
+ const OpenFileSystemCallback& callback) = 0;
// Returns the specialized FileSystemFileUtil for this mount point.
// It is ok to return NULL if the filesystem doesn't support synchronous

Powered by Google App Engine
This is Rietveld 408576698