Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 16043006: Rename FileSystemMountPointProvider::ValidateFileSystemRoot to OpenFileSystem (Closed)

Created:
7 years, 7 months ago by kinuko
Modified:
7 years, 6 months ago
Reviewers:
benjhayden, tzik, kinaba
CC:
chromium-reviews, nkostylev+watch_chromium.org, benjhayden+dwatch_chromium.org, tzik+watch_chromium.org, jam, joi+watch-content_chromium.org, Aaron Boodman, rginda+watch_chromium.org, darin-cc_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, markusheintz_, stevenjb+watch_chromium.org, kinuko+watch, davemoore+watch_chromium.org
Visibility:
Public.

Description

Rename FileSystemMountPointProvider::ValidateFileSystemRoot to OpenFileSystem This patch does: - Rename ValidateFileSystemRoot() to OpenFileSystem() to make it clearer what the method does (as the method is called in response to OpenFileSystem request from the renderer) - Also change boolean 'create' parameter to an enum (OpenFileSystemMode) BUG=243216 R=benjhayden@chromium.org, kinaba@chromium.org, tzik@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202801

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -115 lines) Patch
M chrome/browser/browsing_data/browsing_data_file_system_helper_unittest.cc View 2 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/file_browser_handler_api.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/file_handler_util.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/downloads/downloads_api_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/api/sync_file_system/sync_file_system_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/fileapi/media_file_system_mount_point_provider.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/media_file_system_mount_point_provider.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/fileapi/fileapi_message_filter.cc View 1 chunk +5 lines, -1 line 0 comments Download
M webkit/blob/blob_url_request_job_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/copy_or_move_file_validator_unittest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/file_system_dir_url_request_job_unittest.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M webkit/browser/fileapi/file_system_mount_point_provider.h View 3 chunks +9 lines, -7 lines 0 comments Download
M webkit/browser/fileapi/file_system_url_request_job_unittest.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M webkit/browser/fileapi/isolated_mount_point_provider.h View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/browser/fileapi/isolated_mount_point_provider.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/browser/fileapi/local_file_system_cross_operation_unittest.cc View 1 chunk +8 lines, -4 lines 0 comments Download
A webkit/browser/fileapi/open_file_system_mode.h View 1 chunk +22 lines, -0 lines 0 comments Download
M webkit/browser/fileapi/sandbox_mount_point_provider.h View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/browser/fileapi/sandbox_mount_point_provider.cc View 3 chunks +12 lines, -10 lines 0 comments Download
M webkit/browser/fileapi/sandbox_mount_point_provider_unittest.cc View 9 chunks +30 lines, -20 lines 0 comments Download
M webkit/browser/fileapi/webkit_browser_fileapi.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/chromeos/fileapi/cros_mount_point_provider.h View 2 chunks +4 lines, -4 lines 0 comments Download
M webkit/chromeos/fileapi/cros_mount_point_provider.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/fileapi/file_system_context.h View 2 chunks +4 lines, -2 lines 0 comments Download
M webkit/fileapi/file_system_context.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M webkit/fileapi/file_system_file_stream_reader_unittest.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M webkit/fileapi/syncable/canned_syncable_file_system.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webkit/fileapi/test_mount_point_provider.h View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/fileapi/test_mount_point_provider.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/fileapi/upload_file_system_file_element_reader_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M webkit/tools/test_shell/simple_file_system.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
kinuko
No behavioral changes, intended for cleanup. PTL thanks!
7 years, 7 months ago (2013-05-27 10:52:40 UTC) #1
tzik
lgtm
7 years, 7 months ago (2013-05-27 15:30:45 UTC) #2
kinuko
kinaba: can you review c/b/c/e/file_manager changes? benjhayden: can you review c/b/e/api/downloads change? Thanks,
7 years, 7 months ago (2013-05-28 03:31:19 UTC) #3
kinaba
file_manager lgtm
7 years, 7 months ago (2013-05-28 03:33:15 UTC) #4
benjhayden
*/downloads/* LGTM
7 years, 6 months ago (2013-05-28 13:39:28 UTC) #5
kinuko
7 years, 6 months ago (2013-05-29 07:44:54 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 manually as r202801.

Powered by Google App Engine
This is Rietveld 408576698