Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 1604243002: Revert of [runtime] Introduce maps for the likely cases of FromPropertyDescriptor. (Closed)

Created:
4 years, 11 months ago by Michael Hablich
Modified:
4 years, 11 months ago
Reviewers:
Benedikt Meurer, Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [runtime] Introduce maps for the likely cases of FromPropertyDescriptor. (patchset #1 id:1 of https://codereview.chromium.org/1607943003/ ) Reason for revert: Predecessor CL suspect for roll breakage: https://codereview.chromium.org/1610563002 Original issue's description: > [runtime] Introduce maps for the likely cases of FromPropertyDescriptor. > > This change improves performance for the common case of > Object.getOwnPropertyDescriptor by up 3x-4x, where we just > return a property descriptor object for a regular data or > accessor property. > > R=yangguo@chromium.org > > Committed: https://crrev.com/ffa9e82235b20c523ebb1151c6196bc6232296b9 > Cr-Commit-Position: refs/heads/master@{#33398} TBR=yangguo@chromium.org,bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/8f67a6e710ef311100910f12c617b100e56d0e78 Cr-Commit-Position: refs/heads/master@{#33403}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -178 lines) Patch
M src/bootstrapper.cc View 1 chunk +0 lines, -83 lines 0 comments Download
M src/contexts.h View 2 chunks +0 lines, -3 lines 0 comments Download
M src/objects.h View 1 chunk +0 lines, -46 lines 0 comments Download
M src/property-descriptor.h View 1 chunk +0 lines, -10 lines 0 comments Download
M src/property-descriptor.cc View 3 chunks +2 lines, -36 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Michael Hablich
Created Revert of [runtime] Introduce maps for the likely cases of FromPropertyDescriptor.
4 years, 11 months ago (2016-01-20 11:54:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1604243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1604243002/1
4 years, 11 months ago (2016-01-20 11:54:31 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-20 11:54:42 UTC) #3
commit-bot: I haz the power
4 years, 11 months ago (2016-01-20 11:55:52 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8f67a6e710ef311100910f12c617b100e56d0e78
Cr-Commit-Position: refs/heads/master@{#33403}

Powered by Google App Engine
This is Rietveld 408576698