Issue 160423: Reduce an error to a warning so as not to cause layout tests, which assert th...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 160423: Reduce an error to a warning so as not to cause layout tests, which assert th... (Closed)

Created:
11 years, 4 months ago by darin (slow to review)

Modified:
9 years, 7 months ago

Reviewers:
brettw, Peter Kasting

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Reduce an error to a warning so as not to cause layout tests, which assert this behavior, to fail. R=brettw BUG=18089 TEST=covered by layout tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22184

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -9 lines)			Patch
	M	webkit/tools/layout_tests/test_expectations.txt	View		1 chunk	+0 lines, -8 lines	0 comments	Download
	M	webkit/tools/test_shell/simple_resource_loader_bridge.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

Peter Kasting

If LayoutTests trip this, can't real pages? Do we really want a DLOG(WARNING), or should ...

11 years, 4 months ago (2009-07-30 22:03:37 UTC) #2

darin (slow to review)

On 2009/07/30 22:03:37, Peter Kasting wrote: > If LayoutTests trip this, can't real pages? > ...

11 years, 4 months ago (2009-07-30 22:09:13 UTC) #3

LGTM