Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 160423: Reduce an error to a warning so as not to cause layout tests, which assert th... (Closed)

Created:
11 years, 4 months ago by darin (slow to review)
Modified:
9 years, 7 months ago
Reviewers:
brettw, Peter Kasting
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Reduce an error to a warning so as not to cause layout tests, which assert this behavior, to fail. R=brettw BUG=18089 TEST=covered by layout tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22184

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -9 lines) Patch
M webkit/tools/layout_tests/test_expectations.txt View 1 chunk +0 lines, -8 lines 0 comments Download
M webkit/tools/test_shell/simple_resource_loader_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
darin (slow to review)
11 years, 4 months ago (2009-07-30 22:00:27 UTC) #1
Peter Kasting
If LayoutTests trip this, can't real pages? Do we really want a DLOG(WARNING), or should ...
11 years, 4 months ago (2009-07-30 22:03:37 UTC) #2
darin (slow to review)
On 2009/07/30 22:03:37, Peter Kasting wrote: > If LayoutTests trip this, can't real pages? > ...
11 years, 4 months ago (2009-07-30 22:09:13 UTC) #3
brettw
11 years, 4 months ago (2009-07-31 16:11:05 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698