Issue 16042017: Fix type tests for null.

Issue 16042017: Fix type tests for null. (Closed)

Created:
7 years, 6 months ago by karlklose

Modified:
7 years, 6 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix type tests for null. BUG=dartbug.com/10901 R=ngeoffray@google.com Committed: https://code.google.com/p/dart/source/detail?r=23388

Patch Set 2 : Address comments. #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -15 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/lib/foreign_helper.dart	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/lib/js_helper.dart	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/lib/js_rti.dart	View	1	6 chunks	+12 lines, -6 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/builder.dart	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download
A +	tests/language/null_is2_test.dart	View		1 chunk	+6 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM https://codereview.chromium.org/16042017/diff/1/sdk/lib/_internal/compiler/implementation/lib/js_rti.dart File sdk/lib/_internal/compiler/implementation/lib/js_rti.dart (right): https://codereview.chromium.org/16042017/diff/1/sdk/lib/_internal/compiler/implementation/lib/js_rti.dart#newcode199 sdk/lib/_internal/compiler/implementation/lib/js_rti.dart:199: return type == null || getConstructorName(type) == JS_OBJECT_CLASS_NAME(); ...

7 years, 6 months ago (2013-05-29 15:21:40 UTC) #2

karlklose

Thanks, Nicolas. https://codereview.chromium.org/16042017/diff/1/sdk/lib/_internal/compiler/implementation/lib/js_rti.dart File sdk/lib/_internal/compiler/implementation/lib/js_rti.dart (right): https://codereview.chromium.org/16042017/diff/1/sdk/lib/_internal/compiler/implementation/lib/js_rti.dart#newcode199 sdk/lib/_internal/compiler/implementation/lib/js_rti.dart:199: return type == null || getConstructorName(type) == ...

7 years, 6 months ago (2013-05-30 08:25:18 UTC) #3

karlklose

7 years, 6 months ago (2013-05-30 08:46:34 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r23388 (presubmit successful).

Expand Messages | Collapse Messages