Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/builder.dart

Issue 16042014: Implement operator== and hashCode for bound closures. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« sdk/lib/_internal/compiler/implementation/lib/js_helper.dart ('K') | « sdk/lib/_internal/compiler/implementation/lib/js_helper.dart ('k') | tests/language/bound_closure_equality_test.dart » ('j') | tests/language/bound_closure_equality_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/ssa/builder.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/ssa/builder.dart (revision 23339)
+++ sdk/lib/_internal/compiler/implementation/ssa/builder.dart (working copy)
@@ -67,8 +67,7 @@
index++;
});
} else {
- // TODO(ahe): I have disabled type optimizations for
- // optional arguments as the types are stored in the wrong
+ // TODO(10938): the types are stored in the wrong order.
kasperl 2013/05/29 13:30:14 TODO -> BUG
ngeoffray 2013/05/29 15:33:19 Done.
// order.
HTypeList parameterTypes =
backend.optimisticParameterTypes(element.declaration,
« sdk/lib/_internal/compiler/implementation/lib/js_helper.dart ('K') | « sdk/lib/_internal/compiler/implementation/lib/js_helper.dart ('k') | tests/language/bound_closure_equality_test.dart » ('j') | tests/language/bound_closure_equality_test.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698