[oilpan] Resurrect a loop-back persistent handle in RefCountedHeapAllocated

Source/wtf/RefCounted.h

 /*
  * Copyright (C) 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 25 matching lines @@
 #define CHECK_REF_COUNTED_LIFECYCLE 1
 #endif
 
 // This base class holds the non-template methods and attributes.
 // The RefCounted class inherits from it reducing the template bloat
 // generated by the compiler (technique called template hoisting).
 class RefCountedBase {
 public:
     void ref()
     {
-#if CHECK_REF_COUNTED_LIFECYCLE
-        // Start thread verification as soon as the ref count gets to 2. This
-        // heuristic reflects the fact that items are often created on one thread
-        // and then given to another thread to be used.
-        // FIXME: Make this restriction tigher. Especially as we move to more
-        // common methods for sharing items across threads like CrossThreadCopier.h
-        // We should be able to add a "detachFromThread" method to make this explicit.
-        if (m_refCount == 1)
-            m_verifier.setShared(true);
-        // If this assert fires, it either indicates a thread safety issue or
-        // that the verification needs to change. See ThreadRestrictionVerifier for
-        // the different modes.
-        ASSERT(m_verifier.isSafeToUse());
-        ASSERT(!m_deletionHasBegun);
-        ASSERT(!m_adoptionIsRequired);
-#endif
-        ++m_refCount;
+        refBase();
     }
 
     bool hasOneRef() const
     {
 #if CHECK_REF_COUNTED_LIFECYCLE
         ASSERT(m_verifier.isSafeToUse());
         ASSERT(!m_deletionHasBegun);
 #endif
         return m_refCount == 1;
     }
@@ skipping 55 matching lines @@
     }
 
     ~RefCountedBase()
     {
 #if CHECK_REF_COUNTED_LIFECYCLE
         ASSERT(m_deletionHasBegun);
         ASSERT(!m_adoptionIsRequired);
 #endif
     }
 
+    void refBase()
+    {
+#if CHECK_REF_COUNTED_LIFECYCLE

[Mads Ager (chromium), 2013/05/29 12:31:06]

When we get into the situation that we have an object with refcount 0 in a
handle that we assign to a refptr these assertions will fire. That seems like a
good thing. We will have to temporarily disable this verification for the
transition period because going to 0 refcount and back up is expected in the
transition period. When we hit this we need to decide whether to temporarily
just flip CHECK_REF_COUNTED_LIFECYCLE to false until we no longer use
RefCountedHeapAllocated. 

[haraken, 2013/05/29 13:37:05]

Disabled the check to make the test case workable. I think we need to anyway
disable the check at some point in order to use RefCountedHeapAllocated.

+        // Start thread verification as soon as the ref count gets to 2. This
+        // heuristic reflects the fact that items are often created on one thread
+        // and then given to another thread to be used.
+        // FIXME: Make this restriction tigher. Especially as we move to more
+        // common methods for sharing items across threads like CrossThreadCopier.h
+        // We should be able to add a "detachFromThread" method to make this explicit.
+        if (m_refCount == 1)
+            m_verifier.setShared(true);
+        // If this assert fires, it either indicates a thread safety issue or
+        // that the verification needs to change. See ThreadRestrictionVerifier for
+        // the different modes.
+        ASSERT(m_verifier.isSafeToUse());
+        ASSERT(!m_deletionHasBegun);
+        ASSERT(!m_adoptionIsRequired);
+#endif
+        ++m_refCount;
+    }
+
     // Returns whether the pointer should be freed or not.
     bool derefBase()
     {
 #if CHECK_REF_COUNTED_LIFECYCLE
         ASSERT(m_verifier.isSafeToUse());
         ASSERT(!m_deletionHasBegun);
         ASSERT(!m_adoptionIsRequired);
 #endif
 
         ASSERT(m_refCount > 0);
@@ skipping 41 matching lines @@
     if (!object)
         return;
     ASSERT(!object->m_deletionHasBegun);
     object->m_adoptionIsRequired = false;
 }
 #endif
 
 template<typename T> class RefCounted : public RefCountedBase {
     WTF_MAKE_NONCOPYABLE(RefCounted); WTF_MAKE_FAST_ALLOCATED;
 public:
+    void ref()
+    {
+        refBase();
+    }
+
     void deref()
     {
         if (derefBase())
             delete static_cast<T*>(this);
     }
 
 protected:
     RefCounted() { }
     ~RefCounted()
     {
     }
 };
 
 template<typename T> class RefCountedCustomAllocated : public RefCountedBase {
     WTF_MAKE_NONCOPYABLE(RefCountedCustomAllocated);
 
 public:
+    void ref()
+    {
+        refBase();
+    }
+
     void deref()
     {
         if (derefBase())
             delete static_cast<T*>(this);
     }
 
 protected:
     ~RefCountedCustomAllocated()
     {
     }
@@ skipping 18 matching lines @@
 inline void RefCountedBase::setDispatchQueueForVerifier(dispatch_queue_t) { }
 #endif
 #endif // HAVE(DISPATCH_H)
 
 } // namespace WTF
 
 using WTF::RefCounted;
 using WTF::RefCountedCustomAllocated;
 
 #endif // RefCounted_h