Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 160416: Add "Get Themes" button to gtk options dialog. (Closed)

Created:
11 years, 4 months ago by Evan Stade
Modified:
9 years, 6 months ago
Reviewers:
tony, Glen Murphy
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)
Visibility:
Public.

Description

Add "Get Themes" button to gtk options dialog. BUG=17641 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22174

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -12 lines) Patch
M chrome/browser/gtk/options/content_page_gtk.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/gtk/options/content_page_gtk.cc View 4 chunks +20 lines, -1 line 0 comments Download
M chrome/browser/views/options/content_page_view.cc View 1 chunk +3 lines, -11 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
Evan Stade
http://codereview.chromium.org/160416/diff/1/2 File chrome/browser/views/options/content_page_view.cc (right): http://codereview.chromium.org/160416/diff/1/2#newcode94 Line 94: GURL(), NEW_FOREGROUND_TAB, PageTransition::LINK); correct me if I'm wrong, ...
11 years, 4 months ago (2009-07-30 21:23:48 UTC) #1
tony
GTK changes LGTM
11 years, 4 months ago (2009-07-30 21:29:17 UTC) #2
Evan Stade
ping Glen
11 years, 4 months ago (2009-07-31 19:34:42 UTC) #3
Glen Murphy
11 years, 4 months ago (2009-07-31 19:54:45 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698