Issue 160412: Add support for moving the mouse so that GetMessagePos would notice....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 160412: Add support for moving the mouse so that GetMessagePos would notice.... (Closed)

Created:
11 years, 4 months ago by darin (slow to review)

Modified:
9 years, 7 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Add support for moving the mouse so that GetMessagePos would notice. R=pkasting BUG=18079 TEST=covered by TabDraggingTest.Tab2OutOfTabStrip Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22097

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -5 lines)			Patch
	M	chrome/browser/automation/automation_provider.cc	View		3 chunks	+25 lines, -4 lines	0 comments	Download
	M	chrome/browser/views/tabs/tab_dragging_test.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

Can this cause Linux/Mac to fail to link? (I don't know if they build this.) ...

11 years, 4 months ago (2009-07-30 20:34:27 UTC) #2

darin (slow to review)

11 years, 4 months ago (2009-07-30 21:09:36 UTC) #3

On 2009/07/30 20:34:27, Peter Kasting wrote:
> Can this cause Linux/Mac to fail to link?  (I don't know if they build this.)
> 
> LGTM otherwise.

The callsites are protected by #ifdefs.  The try bots concur :-)

Expand Messages | Collapse Messages