Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 16041004: Cleanup: Remove ScopedGenericObj usage in chrome/. (Closed)

Created:
7 years, 7 months ago by Lei Zhang
Modified:
7 years, 6 months ago
CC:
chromium-reviews, tzik+watch_chromium.org, kinuko+watch, chromium-apps-reviews_chromium.org, Aaron Boodman
Visibility:
Public.

Description

Cleanup: Remove ScopedGenericObj usage in chrome/. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202754

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : rebase #

Patch Set 5 : fix compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -37 lines) Patch
M chrome/browser/extensions/api/system_info_storage/storage_info_provider_linux.cc View 1 2 3 4 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/native_media_file_util.cc View 1 2 3 4 3 chunks +7 lines, -9 lines 0 comments Download
M chrome/browser/storage_monitor/storage_monitor_linux.cc View 1 2 3 4 2 chunks +11 lines, -8 lines 0 comments Download
M chrome/browser/storage_monitor/udev_util_linux.h View 1 2 3 4 2 chunks +10 lines, -17 lines 0 comments Download
M chrome/browser/storage_monitor/udev_util_linux.cc View 1 2 3 4 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Lei Zhang
https://codereview.chromium.org/16041004/diff/1/chrome/browser/extensions/api/system_info_storage/storage_info_provider_linux.cc File chrome/browser/extensions/api/system_info_storage/storage_info_provider_linux.cc (right): https://codereview.chromium.org/16041004/diff/1/chrome/browser/extensions/api/system_info_storage/storage_info_provider_linux.cc#newcode14 chrome/browser/extensions/api/system_info_storage/storage_info_provider_linux.cc:14: using chrome::GetUdevDevicePropertyValue; I don't know how the code ever ...
7 years, 7 months ago (2013-05-25 00:49:28 UTC) #1
vandebo (ex-Chrome)
LGTM https://codereview.chromium.org/16041004/diff/5001/chrome/browser/storage_monitor/udev_util_linux.h File chrome/browser/storage_monitor/udev_util_linux.h (right): https://codereview.chromium.org/16041004/diff/5001/chrome/browser/storage_monitor/udev_util_linux.h#newcode28 chrome/browser/storage_monitor/udev_util_linux.h:28: public: nit: remove public
7 years, 6 months ago (2013-05-28 19:01:06 UTC) #2
Lei Zhang
https://codereview.chromium.org/16041004/diff/5001/chrome/browser/storage_monitor/udev_util_linux.h File chrome/browser/storage_monitor/udev_util_linux.h (right): https://codereview.chromium.org/16041004/diff/5001/chrome/browser/storage_monitor/udev_util_linux.h#newcode28 chrome/browser/storage_monitor/udev_util_linux.h:28: public: On 2013/05/28 19:01:07, vandebo wrote: > nit: remove ...
7 years, 6 months ago (2013-05-28 20:37:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/16041004/14002
7 years, 6 months ago (2013-05-28 20:39:55 UTC) #4
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=5347
7 years, 6 months ago (2013-05-28 20:51:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/16041004/14002
7 years, 6 months ago (2013-05-28 22:51:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/16041004/39001
7 years, 6 months ago (2013-05-28 23:31:13 UTC) #7
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 6 months ago (2013-05-29 00:30:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/16041004/39001
7 years, 6 months ago (2013-05-29 01:32:45 UTC) #9
commit-bot: I haz the power
7 years, 6 months ago (2013-05-29 02:48:11 UTC) #10
Message was sent while issue was closed. 
Change committed as 202754

Powered by Google App Engine
This is Rietveld 408576698