Subzero: Always enable --echo-cmd in the lit tests.

Subzero: Always enable --echo-cmd in the lit tests.

BUG= none
R=stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=d91d3699f06b730cac3e35a97611d9e4c9ee163a

[rkotlerimgtec, 2016-01-20 01:01:40]

Description was changed from

==========
allow for echo-cmd to work with lit

BUG=
==========

to

==========
allow for echo-cmd to work with lit

By setting environment variable PNACL_CHECK_CMD=True, then
when make -f Makefile.standalone check-lit is run, the exact cmd (under [cmd])_
will be in the output. It took some detective work to figure out where to do
this. I think it's possible to add it to the makefile but I at least want to get
this checked in because it's very useful for debugging check-list failures.

BUG=
==========

[rkotlerimgtec, 2016-01-20 01:01:40]

rkotlerimgtec@gmail.com changed reviewers:
+ jpp@chromium.org, kschimpf@chromium.org, stichnot@chromium.org

[rkotlerimgtec, 2016-01-20 02:35:55]

On 2016/01/20 01:02:00, rkotlerimgtec wrote:

Just to be clear, this patch is for recovering the exact command sequence when
filecheck itself fails during a make check.

If, for example, the diassembler fails on some illegal instruction, then you can
extract the sequence from the python traceback even with the current scripts.

[Jim Stichnoth, 2016-01-20 14:53:23]

What do you think about enabling --echo-cmd always?  See the patch below.

Also, to be honest, I think I'd be happy eliminating shellcmd's '[cmd]' output
prefix entirely, without which I can just triple-click the output line and paste
it.

diff --git a/pydir/utils.py b/pydir/utils.py
index 6039e77..a388fd4 100644
--- a/pydir/utils.py
+++ b/pydir/utils.py
@@ -6,7 +6,7 @@ def shellcmd(command, echo=True):
     if not isinstance(command, str):
         command = ' '.join(command)
 
-    if echo: print '[cmd]', command
+    if echo: print >> sys.stderr, '[cmd]', command
 
     stdout_result = subprocess.check_output(command, shell=True)
     if echo: sys.stdout.write(stdout_result)
diff --git a/tests_lit/lit.cfg b/tests_lit/lit.cfg
index b49ee84..53afcd3 100644
--- a/tests_lit/lit.cfg
+++ b/tests_lit/lit.cfg
@@ -87,6 +87,7 @@ iflc2i_atts_cmd = if_atts +
[if_cond_flag('allow_llvm_ir_as_input'
 
 # Base command for running pnacl-sz
 pnacl_sz_cmd = [os.path.join(pydir, 'run-pnacl-sz.py'),
+                '--echo-cmd',
                 '--pnacl-sz', pnacl_sz_tool,
                 '--pnacl-bin-path', pnaclbinpath]
 if 'FORCEASM' in lit_config.params:

[native-client-reviews_googlegroups.com, 2016-01-20 18:22:27]

On Wed, Jan 20, 2016 at 6:53 AM, <stichnot@chromium.org> wrote:

> What do you think about enabling --echo-cmd always?  See the patch below.
>
> Also, to be honest, I think I'd be happy eliminating shellcmd's '[cmd]'
> output
> prefix entirely, without which I can just triple-click the output line and
> paste
> it.
>
If you do eliminate the [cmd] prefix (and please, do!), then please add a
new line after printing the command -- otherwise finding the command you
want from the list will be hard.


>
> diff --git a/pydir/utils.py b/pydir/utils.py
> index 6039e77..a388fd4 100644
> --- a/pydir/utils.py
> +++ b/pydir/utils.py
> @@ -6,7 +6,7 @@ def shellcmd(command, echo=True):
>      if not isinstance(command, str):
>          command = ' '.join(command)
>
> -    if echo: print '[cmd]', command
> +    if echo: print >> sys.stderr, '[cmd]', command
>
>      stdout_result = subprocess.check_output(command, shell=True)
>      if echo: sys.stdout.write(stdout_result)
> diff --git a/tests_lit/lit.cfg b/tests_lit/lit.cfg
> index b49ee84..53afcd3 100644
> --- a/tests_lit/lit.cfg
> +++ b/tests_lit/lit.cfg
> @@ -87,6 +87,7 @@ iflc2i_atts_cmd = if_atts +
> [if_cond_flag('allow_llvm_ir_as_input'
>
>  # Base command for running pnacl-sz
>  pnacl_sz_cmd = [os.path.join(pydir, 'run-pnacl-sz.py'),
> +                '--echo-cmd',
>                  '--pnacl-sz', pnacl_sz_tool,
>                  '--pnacl-bin-path', pnaclbinpath]
>  if 'FORCEASM' in lit_config.params:
>
>
> https://codereview.chromium.org/1604063002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to native-client-reviews+unsubscribe@googlegroups.com.
To post to this group, send email to native-client-reviews@googlegroups.com.
Visit this group at https://groups.google.com/group/native-client-reviews.
For more options, visit https://groups.google.com/d/optout.

[rkotlerimgtec, 2016-01-20 21:19:26]

Patchset #2 (id:20001) has been deleted

[Jim Stichnoth, 2016-01-21 01:39:52]

Description was changed from

==========
allow for echo-cmd to work with lit

By setting environment variable PNACL_CHECK_CMD=True, then
when make -f Makefile.standalone check-lit is run, the exact cmd (under [cmd])_
will be in the output. It took some detective work to figure out where to do
this. I think it's possible to add it to the makefile but I at least want to get
this checked in because it's very useful for debugging check-list failures.

BUG=
==========

to

==========
Subzero: Always enable --echo-cmd in the lit tests.

By setting environment variable PNACL_CHECK_CMD=True, then
when make -f Makefile.standalone check-lit is run, the exact cmd (under [cmd])_
will be in the output. It took some detective work to figure out where to do
this. I think it's possible to add it to the makefile but I at least want to get
this checked in because it's very useful for debugging check-list failures.

BUG=
==========

[Jim Stichnoth, 2016-01-21 01:40:08]

Description was changed from

==========
Subzero: Always enable --echo-cmd in the lit tests.

By setting environment variable PNACL_CHECK_CMD=True, then
when make -f Makefile.standalone check-lit is run, the exact cmd (under [cmd])_
will be in the output. It took some detective work to figure out where to do
this. I think it's possible to add it to the makefile but I at least want to get
this checked in because it's very useful for debugging check-list failures.

BUG=
==========

to

==========
Subzero: Always enable --echo-cmd in the lit tests.

BUG= none
==========

[Jim Stichnoth, 2016-01-21 01:42:05]

LGTM.

Note that I made substantial mods to the description, please make alternative
edits if you think something is wrong/missing.

[Jim Stichnoth, 2016-01-22 02:47:30]

Description was changed from

==========
Subzero: Always enable --echo-cmd in the lit tests.

BUG= none
==========

to

==========
Subzero: Always enable --echo-cmd in the lit tests.

BUG= none
R=stichnot@chromium.org

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[Jim Stichnoth, 2016-01-22 02:47:31]

Committed patchset #2 (id:40001) manually as
d91d3699f06b730cac3e35a97611d9e4c9ee163a (presubmit successful).