Issue 160404: The script which verifies whether a crash callstack is known expects the call...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 160404: The script which verifies whether a crash callstack is known expects the call... (Closed)

Created:
11 years, 4 months ago by ananta

Modified:
9 years, 6 months ago

Reviewers:
huanr

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

The script which verifies whether a crash callstack is known expects the callstack to be in lowercase. Converting the recently added Flash callstacks to lowercase. Added a new stack with the associated bug 18083 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22065

Patch Set 1 #

Total comments: 2

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -3 lines)			Patch
	M	chrome/test/data/reliability/known_crashes.txt	View		1 chunk	+7 lines, -3 lines	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

huanr

11 years, 4 months ago (2009-07-30 17:57:58 UTC) #2

http://codereview.chromium.org/160404/diff/1/2
File chrome/test/data/reliability/known_crashes.txt (right):

http://codereview.chromium.org/160404/diff/1/2#newcode90
Line 90: PREFIX :
malloc___webplugindelegateimpl::flashwindowlesswndproc___npapi::plugininstance::npp_write___npapi::pluginstream::trywritetoplugin
remove malloc and change PREFIX to SUBSTRING.

http://codereview.chromium.org/160404/diff/1/2#newcode94
Line 94: 
remove malloc and change PREFIX to SUBSTRING.

Expand Messages | Collapse Messages