Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 1603983002: Fix partial painting with render pipeline throttling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adjust layout assert. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/FrameView.cpp
diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp
index 5d68ff08ec5d03d29a1993c9a870a18a7d54d514..1104f2341b9a2d41a0f9d098c86efaa539ea0120 100644
--- a/third_party/WebKit/Source/core/frame/FrameView.cpp
+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp
@@ -3699,16 +3699,11 @@ void FrameView::paint(GraphicsContext& context, const CullRect& cullRect) const
void FrameView::paint(GraphicsContext& context, const GlobalPaintFlags globalPaintFlags, const CullRect& cullRect) const
{
- // TODO(skyostil): Remove this early-out in favor of painting cached scrollbars.
- if (shouldThrottleRendering())
- return;
FramePainter(*this).paint(context, globalPaintFlags, cullRect);
}
void FrameView::paintContents(GraphicsContext& context, const GlobalPaintFlags globalPaintFlags, const IntRect& damageRect) const
{
- if (shouldThrottleRendering())
- return;
FramePainter(*this).paintContents(context, globalPaintFlags, damageRect);
}
@@ -4004,8 +3999,12 @@ void FrameView::notifyRenderThrottlingObservers()
}
bool becameUnthrottled = wasThrottled && !canThrottleRendering();
- if (becameUnthrottled)
+ if (becameUnthrottled) {
page()->animator().scheduleVisualUpdate(m_frame.get());
+ // Force a full repaint to make sure we regenerate any cached
+ // subsequences for this frame.
+ m_doFullPaintInvalidation = true;
+ }
}
bool FrameView::shouldThrottleRendering() const

Powered by Google App Engine
This is Rietveld 408576698