Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(778)

Issue 1603953005: Revert of sdf: use linear edge distance approximation for all gradient directions (Closed)

Created:
4 years, 11 months ago by mtklein
Modified:
4 years, 11 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of sdf: use linear edge distance approximation for all gradient directions (patchset #1 id:1 of https://codereview.chromium.org/1545893003/ ) Reason for revert: breaks roll? https://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/81753 Original issue's description: > sdf: use linear edge distance approximation for all gradient directions > > Image diff tools tell me there are diffs, but I sure can't see them. > This drops edge_distance() off the chart as far as CPU cost goes. > > BUG=skia:4729 > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1545893003 > > Committed: https://skia.googlesource.com/skia/+/8a87bb4d5c23da83ef406ef87b470afa4217d7a4 TBR=jvanverth@google.com,bsalomon@google.com,reed@google.com,mtklein@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4729 Committed: https://skia.googlesource.com/skia/+/31d59e71cf5a571ff903d64ba2a6f17b715bfcfb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M src/core/SkDistanceFieldGen.cpp View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
mtklein
Created Revert of sdf: use linear edge distance approximation for all gradient directions
4 years, 11 months ago (2016-01-20 00:26:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1603953005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1603953005/1
4 years, 11 months ago (2016-01-20 00:26:48 UTC) #2
commit-bot: I haz the power
4 years, 11 months ago (2016-01-20 00:26:58 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/31d59e71cf5a571ff903d64ba2a6f17b715bfcfb

Powered by Google App Engine
This is Rietveld 408576698