Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1841)

Unified Diff: content/public/browser/download_manager.h

Issue 1603903002: Add an OriginFilterBuilder class for [white|black]listing origins. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed content_unittests. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/download_manager.h
diff --git a/content/public/browser/download_manager.h b/content/public/browser/download_manager.h
index ca367eb3884001a444047a1b2c642c2d5a43ffd9..c7888525db0f7858d0a84999d3eebdff4343a153 100644
--- a/content/public/browser/download_manager.h
+++ b/content/public/browser/download_manager.h
@@ -114,17 +114,14 @@ class CONTENT_EXPORT DownloadManager : public base::SupportsUserData::Data {
scoped_ptr<ByteStreamReader> stream,
const DownloadUrlParameters::OnStartedCallback& on_started) = 0;
- // Remove downloads which are same-origin with the given origin and pertain to
- // the given time constraints. (See |RemoveDownloadsBetween|.)
- virtual int RemoveDownloadsByOriginAndTime(const url::Origin& origin,
- base::Time remove_begin,
- base::Time remove_end) = 0;
-
- // Remove downloads after remove_begin (inclusive) and before remove_end
- // (exclusive). You may pass in null Time values to do an unbounded delete
- // in either direction.
- virtual int RemoveDownloadsBetween(base::Time remove_begin,
- base::Time remove_end) = 0;
+ // Remove downloads whose URLs match the |url_filter| and are within
+ // the given time constraints - after remove_begin (inclusive) and before
+ // remove_end (exclusive). You may pass in null Time values to do an unbounded
+ // delete in either direction.
+ virtual int RemoveDownloadsByOriginAndTime(
+ const base::Callback<bool(const GURL&)>& url_filter,
+ base::Time remove_begin,
+ base::Time remove_end) = 0;
// Remove downloads will delete all downloads that have a timestamp that is
// the same or more recent than |remove_begin|. The number of downloads

Powered by Google App Engine
This is Rietveld 408576698