Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1316)

Unified Diff: content/browser/download/download_manager_impl_unittest.cc

Issue 1603903002: Add an OriginFilterBuilder class for [white|black]listing origins. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed content_unittests. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/download/download_manager_impl_unittest.cc
diff --git a/content/browser/download/download_manager_impl_unittest.cc b/content/browser/download/download_manager_impl_unittest.cc
index 78d13863470dbba57cd22400172016c75346cd70..cdd9f66aabb0ea506b3ca4c8fa6be82caec8f5d4 100644
--- a/content/browser/download/download_manager_impl_unittest.cc
+++ b/content/browser/download/download_manager_impl_unittest.cc
@@ -707,6 +707,12 @@ TEST_F(DownloadManagerTest, RemoveAllDownloads) {
// result in them being removed from the DownloadManager list.
}
+namespace {
+base::Callback<bool(const GURL&)> GetSingleFileFilter(const GURL* url) {
+ return base::Bind(&GURL::operator==, base::Unretained(url));
+}
+}
brettw 2016/02/05 21:26:04 Blank line before here (and after the namespace op
msramek 2016/02/10 14:30:37 Done. Also, renamed this and the test to mention U
+
// Confirm that only downloads with same origin are removed.
TEST_F(DownloadManagerTest, RemoveSameOriginDownloads) {
base::Time now(base::Time::Now());
@@ -720,9 +726,10 @@ TEST_F(DownloadManagerTest, RemoveSameOriginDownloads) {
EXPECT_CALL(GetMockDownloadItem(0), Remove());
EXPECT_CALL(GetMockDownloadItem(1), Remove()).Times(0);
- url::Origin origin_to_clear(download_urls_[0]);
+ base::Callback<bool(const GURL&)> url_filter =
+ GetSingleFileFilter(&download_urls_[0]);
int remove_count = download_manager_->RemoveDownloadsByOriginAndTime(
- origin_to_clear, base::Time(), base::Time::Max());
+ url_filter, base::Time(), base::Time::Max());
EXPECT_EQ(remove_count, 1);
}

Powered by Google App Engine
This is Rietveld 408576698