src/IceInstARM32.cpp - Issue 1603893003: Add vstr{s,d} to the integrated ARM assembler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceInstARM32.cpp

Issue 1603893003: Add vstr{s,d} to the integrated ARM assembler. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Fix nits. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceInstARM32.cpp

diff --git a/src/IceInstARM32.cpp b/src/IceInstARM32.cpp

index a1605828e3eae08637d8615c6632cd633303a5de..f38ec7c66390fd4c39351dabf61a810aa4abca9d 100644

--- a/src/IceInstARM32.cpp

+++ b/src/IceInstARM32.cpp

@@ -1663,7 +1663,12 @@ void InstARM32Str::emitIAS(const Cfg *Func) const {

assert(getSrcSize() == 2);

Type Ty = getSrc(0)->getType();

auto *Asm = Func->getAssembler<ARM32::AssemblerARM32>();

- if (isVectorType(Ty) || isScalarFloatingType(Ty))

+ if (isScalarFloatingType(Ty)) {

+ if (Ty == IceType_f32)

+ Asm->vstrs(getSrc(0), getSrc(1), getPredicate(), Func->getTarget());

+ else

+ Asm->vstrd(getSrc(0), getSrc(1), getPredicate(), Func->getTarget());

+ } else if (isVectorType(Ty))

// TODO(kschimpf) Handle case.

Asm->setNeedsTextFixup();

else

« no previous file with comments | « src/IceAssemblerARM32.cpp ('k') | tests_lit/assembler/arm32/vstr.ll » ('j') | no next file with comments »