Dynamically inserted StyleSheet shouldn't block loading.

Dynamically inserted StyleSheet shouldn't block loading.

BUG=571725
TEST=./blink/tools/run_layout_tests.sh http/tests/css/css-non-blocking.html

Committed: https://crrev.com/bec656722788dbc2f74e15c29d52dfef47089f3d
Cr-Commit-Position: refs/heads/master@{#370646}

[horo, 2016-01-20 05:35:12]

Description was changed from

==========
check isCreatedByParser

BUG=571725
==========

to

==========
Dynamically inserted StyleSheet shouldn't block loading.

BUG=571725
==========

[horo, 2016-01-20 06:16:57]

Description was changed from

==========
Dynamically inserted StyleSheet shouldn't block loading.

BUG=571725
==========

to

==========
Dynamically inserted StyleSheet shouldn't block loading.

BUG=571725
TEST=./blink/tools/run_layout_tests.sh http/tests/css/css-non-blocking.html
==========

[horo, 2016-01-20 06:17:25]

horo@chromium.org changed reviewers:
+ morrita@chromium.org

[horo, 2016-01-20 06:17:25]

morrita@
Could you please review this?

[horo, 2016-01-20 08:33:38]

horo@chromium.org changed reviewers:
+ kouhei@chromium.org

[kouhei (in TOK), 2016-01-20 08:43:37]

Code change lgtm. Let me wait until spec question is resolved.

[bmaurer, 2016-01-20 21:03:02]

Amazing! Thanks for doing this!

How does this affect prioritization? There seems like there is some code to
de-prioritize script non-blocking css -- IMHO this type of stylesheet should
have the same priority as an async script.

Also, can you clarify the spec question you guys have?

[horo, 2016-01-21 05:04:27]

Patchset #4 (id:60001) has been deleted

[horo, 2016-01-21 05:04:34]

Patchset #3 (id:40001) has been deleted

[horo, 2016-01-21 05:17:40]

horo@chromium.org changed reviewers:
+ kenjibaheux@chromium.org

[horo, 2016-01-21 05:18:04]

On 2016/01/20 08:43:37, kouhei wrote:
> Code change lgtm. Let me wait until spec question is resolved.

I discussed with kenjibaheux@ and we agreed to change the behavior.


On 2016/01/20 21:03:02, bmaurer wrote:
> Amazing! Thanks for doing this!
> 
> How does this affect prioritization? There seems like there is some code to
> de-prioritize script non-blocking css -- IMHO this type of stylesheet should
> have the same priority as an async script.

This change deprioritize the dynamic style sheet loading.
We think that it is reasonable because it is not blocking.

Can you open a new crbug to discuss that?

[horo, 2016-01-21 05:18:09]

The CQ bit was checked by horo@chromium.org

[horo, 2016-01-21 05:18:09]

The patchset sent to the CQ was uploaded after l-g-t-m from kouhei@chromium.org
Link to the patchset: https://codereview.chromium.org/1603873004/#ps80001
(title: "update LayoutTests")

[commit-bot: I haz the power, 2016-01-21 05:18:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1603873004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1603873004/80001

[commit-bot: I haz the power, 2016-01-21 07:44:48]

Description was changed from

==========
Dynamically inserted StyleSheet shouldn't block loading.

BUG=571725
TEST=./blink/tools/run_layout_tests.sh http/tests/css/css-non-blocking.html
==========

to

==========
Dynamically inserted StyleSheet shouldn't block loading.

BUG=571725
TEST=./blink/tools/run_layout_tests.sh http/tests/css/css-non-blocking.html
==========

[commit-bot: I haz the power, 2016-01-21 07:44:49]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2016-01-21 07:45:39]

Description was changed from

==========
Dynamically inserted StyleSheet shouldn't block loading.

BUG=571725
TEST=./blink/tools/run_layout_tests.sh http/tests/css/css-non-blocking.html
==========

to

==========
Dynamically inserted StyleSheet shouldn't block loading.

BUG=571725
TEST=./blink/tools/run_layout_tests.sh http/tests/css/css-non-blocking.html

Committed: https://crrev.com/bec656722788dbc2f74e15c29d52dfef47089f3d
Cr-Commit-Position: refs/heads/master@{#370646}
==========

[commit-bot: I haz the power, 2016-01-21 07:45:40]

Patchset 3 (id:??) landed as
https://crrev.com/bec656722788dbc2f74e15c29d52dfef47089f3d
Cr-Commit-Position: refs/heads/master@{#370646}

[Yoav Weiss, 2016-01-21 13:57:43]

On 2016/01/21 07:45:40, commit-bot: I haz the power wrote:
> Patchset 3 (id:??) landed as
> https://crrev.com/bec656722788dbc2f74e15c29d52dfef47089f3d
> Cr-Commit-Position: refs/heads/master@{#370646}

Can we send out a PSA to blink-dev, notifying people of this change?

[esprehn, 2016-01-22 02:15:19]

This should probably have a Sim test.

[horo, 2016-01-22 02:16:09]

On 2016/01/21 13:57:43, Yoav Weiss wrote:
> On 2016/01/21 07:45:40, commit-bot: I haz the power wrote:
> > Patchset 3 (id:??) landed as
> > https://crrev.com/bec656722788dbc2f74e15c29d52dfef47089f3d
> > Cr-Commit-Position: refs/heads/master@{#370646}
> 
> Can we send out a PSA to blink-dev, notifying people of this change?

Done.
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/xvxa1WaFuFc

[horo, 2016-01-22 02:18:51]

On 2016/01/22 02:15:19, esprehn wrote:
> This should probably have a Sim test.

Sorry, what "Sim test" means?

[kinuko, 2016-01-22 05:14:26]

On 2016/01/22 02:18:51, horo wrote:
> On 2016/01/22 02:15:19, esprehn wrote:
> > This should probably have a Sim test.
> 
> Sorry, what "Sim test" means?

Tests that written with SimNetwork + SimRequest etc, the ones we started to have
recently... you can find some examples in
web/tests/DocumentLoadingRenderingTest.cpp
.

(Anyways thanks for working on this!)