Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Issue 1603683003: Disable BackgroundTracingManagerBrowserTest.CallTriggersMoreThanOnceOnlyGatherOnce under TSan. (Closed)

Created:
4 years, 11 months ago by Alexander Potapenko
Modified:
4 years, 9 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, darin-cc_chromium.org, jam, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable BackgroundTracingManagerBrowserTest.CallTriggersMoreThanOnceOnlyGatherOnce under TSan. Turns out the suppression for allocation stack didn't work. Remove it and disable the test instead. BUG=559117 TBR=reillyg@chromium.org,dsinclair@chromium.org Committed: https://crrev.com/431e0ba1472931de155e7540d9ef2385c2e553ca Cr-Commit-Position: refs/heads/master@{#370090}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M build/sanitizers/tsan_suppressions.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/tracing/background_tracing_manager_browsertest.cc View 1 chunk +10 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
Alexander Potapenko
TBR
4 years, 11 months ago (2016-01-19 09:34:39 UTC) #1
Alexander Potapenko
On 2016/01/19 09:34:39, Alexander Potapenko wrote: > TBR + dsinclair@chromium.org
4 years, 11 months ago (2016-01-19 09:35:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1603683003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1603683003/1
4 years, 11 months ago (2016-01-19 09:35:33 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-19 10:06:19 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/431e0ba1472931de155e7540d9ef2385c2e553ca Cr-Commit-Position: refs/heads/master@{#370090}
4 years, 11 months ago (2016-01-19 10:07:28 UTC) #10
Primiano Tucci (use gerrit)
4 years, 9 months ago (2016-03-08 11:16:20 UTC) #11
Message was sent while issue was closed.
On 2016/01/19 10:07:28, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/431e0ba1472931de155e7540d9ef2385c2e553ca
> Cr-Commit-Position: refs/heads/master@{#370090}

For the historians: reverted this in https://codereview.chromium.org/1772873004/
after fixing the race

Powered by Google App Engine
This is Rietveld 408576698