OneClickSigninHelper::CanOffer checks IsEnableWebBasedSignin

chrome/browser/ui/tab_helpers.cc

Index: chrome/browser/ui/tab_helpers.cc
diff --git a/chrome/browser/ui/tab_helpers.cc b/chrome/browser/ui/tab_helpers.cc
index fbf8757eb9b90e5f5d09d0e394ba34e1255521e6..347d594ec73ae2df15ae54a51fa05bdc6f692c21 100644
--- a/chrome/browser/ui/tab_helpers.cc
+++ b/chrome/browser/ui/tab_helpers.cc
@@ -28,6 +28,7 @@
 #include "chrome/browser/ui/prefs/prefs_tab_helper.h"
 #include "chrome/browser/ui/tab_contents/core_tab_helper.h"
 #include "chrome/common/chrome_switches.h"
+#include "chrome/common/profile_management_switches.h"
 #include "components/autofill/content/browser/autofill_driver_impl.h"
 #include "components/autofill/core/browser/autofill_manager.h"
 #include "content/public/browser/web_contents.h"
@@ -203,7 +204,10 @@ void TabHelpers::AttachTabHelpers(WebContents* web_contents) {
   // because the connected state may change while this tab is open.  Having a
   // one-click signin helper attached does not cause problems if the profile
   // happens to be already connected.
-  if (OneClickSigninHelper::CanOffer(web_contents,
+  // TODO(vabr): The check IsEnableWebBasedSignin is a hack for the time when
+  // OneClickSignin is disabled. http://crbug.com/339804
+  if (switches::IsEnableWebBasedSignin() &&

[Avi (use Gerrit), 2014/02/13 16:10:45]

This, and other functions in profile_management_switches.h, read awkwardly in
English. I would prefer

IsEnableWebBasedSignin -> IsWebBasedSigninEnabled
IsGoogleProfileInfo() -> IsGoogleProfileInfoUsed (maybe not "used" but this
needs a verb)
IsNewProfileManagement -> IsNewProfileManagementEnabled

This rename is almost certainly out of the scope of this change, though.

[vabr (Chromium), 2014/02/13 16:24:23]

Thanks for the comment. I second that it is out of scope of this CL, but Roger
mentioned some refactoring planned, which could possible handle this.

+      OneClickSigninHelper::CanOffer(web_contents,
                                      OneClickSigninHelper::CAN_OFFER_FOR_ALL,
                                      std::string(),
                                      NULL)) {