OneClickSigninHelper::CanOffer checks IsEnableWebBasedSignin

chrome/browser/ui/sync/one_click_signin_helper_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "base/command_line.h"
 #include "base/prefs/pref_service.h"
 #include "base/prefs/scoped_user_pref_update.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/values.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/content_settings/cookie_settings.h"
 #include "chrome/browser/custom_handlers/protocol_handler_registry.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profile_info_cache.h"
 #include "chrome/browser/profiles/profile_io_data.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/signin/fake_profile_oauth2_token_service.h"
 #include "chrome/browser/signin/fake_signin_manager.h"
 #include "chrome/browser/signin/profile_oauth2_token_service.h"
 #include "chrome/browser/signin/profile_oauth2_token_service_factory.h"
 #include "chrome/browser/signin/signin_manager.h"
 #include "chrome/browser/signin/signin_manager_factory.h"
 #include "chrome/browser/signin/signin_names_io_thread.h"
 #include "chrome/browser/signin/signin_promo.h"
 #include "chrome/browser/sync/profile_sync_service_factory.h"
 #include "chrome/browser/sync/profile_sync_service_mock.h"
 #include "chrome/browser/sync/test_profile_sync_service.h"
 #include "chrome/browser/ui/sync/one_click_signin_helper.h"
 #include "chrome/browser/ui/webui/signin/login_ui_service.h"
 #include "chrome/browser/ui/webui/signin/login_ui_service_factory.h"
+#include "chrome/common/chrome_switches.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/test/base/chrome_render_view_host_test_harness.h"
 #include "chrome/test/base/testing_browser_process.h"
 #include "chrome/test/base/testing_pref_service_syncable.h"
 #include "chrome/test/base/testing_profile.h"
 #include "chrome/test/base/testing_profile_manager.h"
 #include "components/autofill/core/common/password_form.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/navigation_details.h"
 #include "content/public/browser/web_contents.h"
@@ skipping 146 matching lines @@
          first_setup_in_progress_(false) {}
 
    bool first_setup_in_progress_;
 };
 
 }  // namespace
 
 class OneClickSigninHelperTest : public ChromeRenderViewHostTestHarness {
  public:
   OneClickSigninHelperTest();
+  virtual ~OneClickSigninHelperTest();
 
   virtual void SetUp() OVERRIDE;
   virtual void TearDown() OVERRIDE;
 
   // Creates the sign-in manager for tests.  If |username| is
   // is not empty, the profile of the mock WebContents will be connected to
   // the given account.
   void CreateSigninManager(const std::string& username);
 
   // Set the ID of the signin process that the test will assume to be the
   // only process allowed to sign the user in to Chrome.
   void SetTrustedSigninProcessID(int id);
 
   void AddEmailToOneClickRejectedList(const std::string& email);
   void EnableOneClick(bool enable);
   void AllowSigninCookies(bool enable);
   void SetAllowedUsernamePattern(const std::string& pattern);
   ProfileSyncServiceMock* CreateProfileSyncServiceMock();
   void SubmitGAIAPassword(OneClickSigninHelper* helper);
 
   SigninManagerMock* signin_manager_;
   FakeProfileOAuth2TokenService* fake_oauth2_token_service_;
 
  protected:
+  enum SetupArgument { ENABLE_WEB_BASED_SIGNIN, DISABLE_WEB_BASED_SIGNIN };
+
+  // A helper method to SetUp(void).
+  void SetUp(SetupArgument arg);
+
   GoogleServiceAuthError no_error_;
 
  private:
   // ChromeRenderViewHostTestHarness overrides:
   virtual content::BrowserContext* CreateBrowserContext() OVERRIDE;
 
   // The ID of the signin process the test will assume to be trusted.
   // By default, set to the test RenderProcessHost's process ID, but
   // overridden by SetTrustedSigninProcessID.
   int trusted_signin_process_id_;
 
   DISALLOW_COPY_AND_ASSIGN(OneClickSigninHelperTest);
 };
 
 OneClickSigninHelperTest::OneClickSigninHelperTest()
     : signin_manager_(NULL),
       fake_oauth2_token_service_(NULL),
       no_error_(GoogleServiceAuthError::NONE),
       trusted_signin_process_id_(-1) {
 }
 
+OneClickSigninHelperTest::~OneClickSigninHelperTest() {}
+
 void OneClickSigninHelperTest::SetUp() {
+  SetUp(ENABLE_WEB_BASED_SIGNIN);
+}
+
+void OneClickSigninHelperTest::SetUp(SetupArgument arg) {
+  if (arg == ENABLE_WEB_BASED_SIGNIN) {
+    CommandLine::ForCurrentProcess()->AppendSwitch(
+        switches::kEnableWebBasedSignin);
+  }
   signin::ForceWebBasedSigninFlowForTesting(true);
   content::RenderViewHostTestHarness::SetUp();
   SetTrustedSigninProcessID(process()->GetID());
 }
 
 void OneClickSigninHelperTest::TearDown() {
   signin::ForceWebBasedSigninFlowForTesting(false);
   content::RenderViewHostTestHarness::TearDown();
 }
 
@@ skipping 75 matching lines @@
   fake_oauth2_token_service_ =
       static_cast<FakeProfileOAuth2TokenService*>(
           ProfileOAuth2TokenServiceFactory::GetForProfile(profile.get()));
 
   return profile.release();
 }
 
 class OneClickSigninHelperIOTest : public OneClickSigninHelperTest {
  public:
   OneClickSigninHelperIOTest();
+  virtual ~OneClickSigninHelperIOTest();
 
   virtual void SetUp() OVERRIDE;
 
   TestProfileIOData* CreateTestProfileIOData(bool is_incognito);
 
  protected:
   TestingProfileManager testing_profile_manager_;
   TestURLRequest request_;
   const GURL valid_gaia_url_;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(OneClickSigninHelperIOTest);
 };
 
 OneClickSigninHelperIOTest::OneClickSigninHelperIOTest()
     : testing_profile_manager_(
           TestingBrowserProcess::GetGlobal()),
       valid_gaia_url_("https://accounts.google.com/") {
 }
 
+OneClickSigninHelperIOTest::~OneClickSigninHelperIOTest() {}
+
 void OneClickSigninHelperIOTest::SetUp() {
   OneClickSigninHelperTest::SetUp();
   ASSERT_TRUE(testing_profile_manager_.SetUp());
 }
 
 TestProfileIOData* OneClickSigninHelperIOTest::CreateTestProfileIOData(
     bool is_incognito) {
   PrefService* pref_service = profile()->GetPrefs();
   PrefService* local_state = g_browser_process->local_state();
   CookieSettings* cookie_settings =
@@ skipping 11 matching lines @@
 };
 
 content::BrowserContext*
 OneClickSigninHelperIncognitoTest::CreateBrowserContext() {
   // Builds an incognito profile to run this test.
   TestingProfile::Builder builder;
   builder.SetIncognito();
   return builder.Build().release();
 }
 
+class OneClickSigninHelperDisableWebBasedSigninTest
+    : public OneClickSigninHelperTest {
+ public:
+  // No additional data members => no need to declare a virtual destructor.
+  virtual void SetUp() OVERRIDE;
+};
+
+void OneClickSigninHelperDisableWebBasedSigninTest::SetUp() {
+  OneClickSigninHelperTest::SetUp(DISABLE_WEB_BASED_SIGNIN);
+}

[Roger Tawa OOO till Jul 10th, 2014/02/12 15:36:50]

Please use testing::TestWithParam and TEST_P macro to setup tests with and
without the command line flag.  See accelerator_commands_browsertest.cc for an
example.

[vabr (Chromium), 2014/02/12 18:42:15]

Modifications to the unit-test dropped.

+
 TEST_F(OneClickSigninHelperTest, CanOfferNoContents) {
   std::string error_message;
   EXPECT_FALSE(OneClickSigninHelper::CanOffer(
       NULL, OneClickSigninHelper::CAN_OFFER_FOR_INTERSTITAL_ONLY,
       "user@gmail.com", &error_message));
   EXPECT_EQ("", error_message);
   EXPECT_FALSE(OneClickSigninHelper::CanOffer(
       NULL, OneClickSigninHelper::CAN_OFFER_FOR_ALL,
       "user@gmail.com", &error_message));
   EXPECT_EQ("", error_message);
@@ skipping 440 matching lines @@
       prefs::kSigninAllowed, base::Value::CreateBooleanValue(true));
 
   // Simulate a policy disabling sync by writing kSyncManaged directly.
   // We should still offer to sign in the browser.
   profile()->GetTestingPrefService()->SetManagedPref(
       prefs::kSyncManaged, base::Value::CreateBooleanValue(true));
   EXPECT_EQ(OneClickSigninHelper::CAN_OFFER,
             OneClickSigninHelper::CanOfferOnIOThreadImpl(
                 valid_gaia_url_, &request_, io_data.get()));
 }
+
+TEST_F(OneClickSigninHelperDisableWebBasedSigninTest, CanOffer) {
+  CreateSigninManager(std::string());
+
+  EXPECT_CALL(*signin_manager_, IsAllowedUsername(_)).
+        WillRepeatedly(Return(true));

[Roger Tawa OOO till Jul 10th, 2014/02/12 15:36:50]

Indent 2 less.

[vabr (Chromium), 2014/02/12 18:42:15]

Modifications to the unit-test dropped.

+
+  // Whithout the "enable-web-based-signin" flag, CanOffer should always return
+  // false, independently of the OneClick setting.
+  for (int i = 0; i < 2; ++i) {
+    bool enable_one_click = !i;
+    EnableOneClick(enable_one_click);
+    SCOPED_TRACE(testing::Message()
+                 << "enable_one_click = " << enable_one_click);
+    std::string error_message;
+
+    EXPECT_FALSE(OneClickSigninHelper::CanOffer(
+        web_contents(),
+        OneClickSigninHelper::CAN_OFFER_FOR_INTERSTITAL_ONLY,
+        "user@gmail.com",
+        &error_message));
+    EXPECT_EQ("", error_message);
+    EXPECT_FALSE(
+        OneClickSigninHelper::CanOffer(web_contents(),
+                                       OneClickSigninHelper::CAN_OFFER_FOR_ALL,
+                                       "user@gmail.com",
+                                       &error_message));
+    EXPECT_EQ("", error_message);
+    EXPECT_FALSE(OneClickSigninHelper::CanOffer(
+        web_contents(),
+        OneClickSigninHelper::CAN_OFFER_FOR_INTERSTITAL_ONLY,
+        std::string(),
+        &error_message));
+    EXPECT_EQ("", error_message);
+  }
+}